Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 #3271

ndimiduk · 2021-05-14T16:53:39Z

Signed-off-by: Nick Dimiduk [email protected]

ndimiduk · 2021-05-14T16:55:29Z

FYI @ZhaoBQ , looks like your patch applies well enough to branch-2. Can you confirm that it can be applied without modification -- the configs you manipulate in this branch don't need some different action for the next 2.x release, and that there are not other uses of addDeprecation on branch-2 that need to be corrected? Thanks for the contribution!

ZhaoBQ · 2021-05-15T08:30:23Z

hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java

+      new DeprecationDelta("hlog.input.tables", "wal.input.tables"),
+      new DeprecationDelta("hlog.input.tablesmap", "wal.input.tablesmap"),
+      new DeprecationDelta("hbase.master.mob.ttl.cleaner.period",
+        "hbase.master.mob.cleaner.period")


branch-2 doesn't have this configuration, so it needs to be deleted. The rest doesn't need to change.

Yes, there is nothing else to modify.

…#3249) Signed-off-by: Nick Dimiduk <[email protected]>

…ch-2

Apache-HBase · 2021-05-17T21:24:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	branch-2 passed
+1 💚	compile	8m 46s	branch-2 passed
+1 💚	checkstyle	2m 5s	branch-2 passed
+0 🆗	refguide	3m 50s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	11m 38s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	8m 42s	the patch passed
+1 💚	javac	8m 42s	the patch passed
+1 💚	checkstyle	2m 4s	root: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+0 🆗	refguide	3m 20s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 42s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	12m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		82m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3271
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide
uname	Linux 0c0699a94e8a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1a8d3c3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/branch-site/book.html
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	141 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-18T00:47:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 46s	branch-2 passed
+1 💚	compile	3m 9s	branch-2 passed
+1 💚	shadedjars	7m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 29s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 31s	the patch passed
+1 💚	compile	3m 7s	the patch passed
-0 ⚠️	javac	3m 7s	root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)
+1 💚	shadedjars	7m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	240m 28s	root in the patch passed.
		285m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3271
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 033a767c345b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1a8d3c3`
Default Java	AdoptOpenJDK-11.0.10+9
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/
Max. process+thread count	4074 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-18T02:01:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	branch-2 passed
+1 💚	compile	2m 8s	branch-2 passed
+1 💚	shadedjars	5m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 29s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	2m 12s	the patch passed
-0 ⚠️	javac	2m 12s	root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)
+1 💚	shadedjars	5m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	321m 17s	root in the patch passed.
		359m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3271
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 477ccf1ae865 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `1a8d3c3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/
Max. process+thread count	4662 (vs. ulimit of 12500)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

This comment has been minimized.

Sign in to view

ZhaoBQ reviewed May 15, 2021

View reviewed changes

ZhaoBQ and others added 2 commits May 17, 2021 12:55

HBASE-25861 Correct the usage of Configuration#addDeprecation (apache…

dd03b98

…#3249) Signed-off-by: Nick Dimiduk <[email protected]>

delete hbase.master.mob.ttl.cleaner.period - not applicable to bran…

2e1810d

…ch-2

ndimiduk force-pushed the 25861-correct-addDeprecation-branch-2 branch from 7614a9e to 2e1810d Compare May 17, 2021 20:01

ndimiduk merged commit aab6e1d into apache:branch-2 May 18, 2021

ndimiduk deleted the 25861-correct-addDeprecation-branch-2 branch May 18, 2021 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 #3271

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 #3271

Uh oh!

ndimiduk commented May 14, 2021

Uh oh!

ndimiduk commented May 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ZhaoBQ May 15, 2021

Uh oh!

ndimiduk May 17, 2021

Uh oh!

ZhaoBQ May 18, 2021

Uh oh!

Apache-HBase commented May 17, 2021

Uh oh!

Apache-HBase commented May 18, 2021

Uh oh!

Apache-HBase commented May 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 #3271

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 #3271

Uh oh!

Conversation

ndimiduk commented May 14, 2021

Uh oh!

ndimiduk commented May 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ZhaoBQ May 15, 2021

Choose a reason for hiding this comment

Uh oh!

ndimiduk May 17, 2021

Choose a reason for hiding this comment

Uh oh!

ZhaoBQ May 18, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 17, 2021

Uh oh!

Apache-HBase commented May 18, 2021

Uh oh!

Apache-HBase commented May 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants