Skip to content

Backport "HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)" to branch-2.3 #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndimiduk merged 1 commit into from
Apr 13, 2021
Merged

Backport "HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)" to branch-2.3 #3157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions ...erver/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@ private double getAverageRegionSizeMb(final List<RegionInfo> tableRegions) {
if (tableDescriptor != null) {
targetRegionCount = tableDescriptor.getNormalizerTargetRegionCount();
targetRegionSize = tableDescriptor.getNormalizerTargetRegionSize();
LOG.debug("Table {} configured with target region count {}, target region size {}", table,
targetRegionCount, targetRegionSize);
LOG.debug("Table {} configured with target region count {}, target region size {} MB",
table, targetRegionCount, targetRegionSize);
}
} catch (IOException e) {
LOG.warn("TableDescriptor for {} unavailable, table-level target region count and size"
Expand All @@ -332,8 +332,8 @@ private double getAverageRegionSizeMb(final List<RegionInfo> tableRegions) {
} else {
avgRegionSize = totalSizeMb / (double) regionCount;
}
LOG.debug("Table {}, total aggregated regions size: {} and average region size {}", table,
totalSizeMb, avgRegionSize);
LOG.debug("Table {}, total aggregated regions size: {} MB and average region size {} MB",
table, totalSizeMb, String.format("%.3f", avgRegionSize));
}

return avgRegionSize;
Expand Down Expand Up @@ -373,7 +373,7 @@ private List<NormalizationPlan> computeMergeNormalizationPlans(final NormalizeCo
}

final double avgRegionSizeMb = ctx.getAverageRegionSizeMb();
LOG.debug("Computing normalization plan for table {}. average region size: {}, number of"
LOG.debug("Computing normalization plan for table {}. average region size: {} MB, number of"
+ " regions: {}.", ctx.getTableName(), avgRegionSizeMb, ctx.getTableRegions().size());

final List<NormalizationPlan> plans = new ArrayList<>();
Expand Down Expand Up @@ -418,7 +418,8 @@ private static boolean skipForSplit(final RegionState state, final RegionInfo re
*/
private List<NormalizationPlan> computeSplitNormalizationPlans(final NormalizeContext ctx) {
final double avgRegionSize = ctx.getAverageRegionSizeMb();
LOG.debug("Table {}, average region size: {}", ctx.getTableName(), avgRegionSize);
LOG.debug("Table {}, average region size: {} MB", ctx.getTableName(),
String.format("%.3f", avgRegionSize));

final List<NormalizationPlan> plans = new ArrayList<>();
for (final RegionInfo hri : ctx.getTableRegions()) {
Expand All @@ -427,8 +428,9 @@ private List<NormalizationPlan> computeSplitNormalizationPlans(final NormalizeCo
}
final long regionSize = getRegionSizeMB(hri);
if (regionSize > 2 * avgRegionSize) {
LOG.info("Table {}, large region {} has size {}, more than twice avg size {}, splitting",
ctx.getTableName(), hri.getRegionNameAsString(), regionSize, avgRegionSize);
LOG.info("Table {}, large region {} has size {} MB, more than twice avg size {} MB, splitting",
ctx.getTableName(), hri.getRegionNameAsString(), regionSize,
String.format("%.3f", avgRegionSize));
plans.add(new SplitNormalizationPlan(hri));
}
}
Expand Down