Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented May 26, 2019

No description provided.

@Override
protected void setupConf(Configuration conf) {
super.setupConf(conf);
conf.setBoolean(HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Looks like this wasn't tested before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no new code here, the only problem is that the test method for killing rs carrying meta is time consuming, so I split them into individual test classes so we do not timeout...

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 11 new or modified test files.
_ master Compile Tests _
+1 mvninstall 270 master passed
+1 compile 50 master passed
+1 checkstyle 73 master passed
+1 shadedjars 265 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 166 master passed
+1 javadoc 33 master passed
_ Patch Compile Tests _
+1 mvninstall 246 the patch passed
+1 compile 51 the patch passed
+1 javac 51 the patch passed
+1 checkstyle 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1005 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1 findbugs 168 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 14210 hbase-server in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
17332
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/Dockerfile
GITHUB PR #253
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 92f2e0cee2ac 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 27c02a0
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/testReport/
Max. process+thread count 4735 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 998b841 into apache:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants