Skip to content

Conversation

@murtazahassan123
Copy link
Contributor

Changed configuration and analyzed code with rubocop on some files and it works.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 282 Docker mode activated.
_ Prechecks _
0 yamllint 0 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 314 master passed
+1 javadoc 15 master passed
_ Patch Compile Tests _
+1 mvninstall 301 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 javadoc 14 the patch passed
_ Other Tests _
+1 unit 634 hbase-shell in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
1641
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/artifact/out/Dockerfile
GITHUB PR #224
Optional Tests dupname asflicense javac javadoc unit yamllint
uname Linux e1899f3870bb 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6de308c
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/testReport/
Max. process+thread count 2574 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for the re-triggered Q&A.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 49 Docker mode activated.
_ Prechecks _
0 yamllint 1 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 309 master passed
+1 javadoc 15 master passed
_ Patch Compile Tests _
+1 mvninstall 323 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 javadoc 14 the patch passed
_ Other Tests _
+1 unit 674 hbase-shell in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
1467
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/artifact/out/Dockerfile
GITHUB PR #224
Optional Tests dupname asflicense javac javadoc unit yamllint
uname Linux 2d38ddcc76ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6de308c
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/testReport/
Max. process+thread count 2519 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mixed the ticket numbers. The change actually looks like HBASE-20851, instead of HBASE-22358.

@murtazahassan123 murtazahassan123 changed the title HBASE-22358 Change rubocop configuration for method length HBASE-20851 Change rubocop config for max line length of 100 May 7, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
0 yamllint 0 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 298 master passed
+1 javadoc 15 master passed
_ Patch Compile Tests _
+1 mvninstall 307 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 javadoc 15 the patch passed
_ Other Tests _
+1 unit 625 hbase-shell in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
1382
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/artifact/out/Dockerfile
GITHUB PR #224
Optional Tests dupname asflicense javac javadoc unit yamllint
uname Linux 5c2b174475e5 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6de308c
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/testReport/
Max. process+thread count 2574 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-224/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit 2005122 into apache:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants