HBASE-22368 Use LocalDate instead of Date for MobUtil class #223

ArthurSXL8 · 2019-05-07T02:26:09Z

No description provided.

Apache-HBase · 2019-05-07T05:23:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	20	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	259	master passed
+1	compile	54	master passed
+1	checkstyle	75	master passed
+1	shadedjars	268	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	197	master passed
+1	javadoc	35	master passed
		_ Patch Compile Tests _
+1	mvninstall	249	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
-1	checkstyle	73	hbase-server: The patch generated 93 new + 46 unchanged - 20 fixed = 139 total (was 66)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	513	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	228	the patch passed
+1	javadoc	33	the patch passed
		_ Other Tests _
-1	unit	8128	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		10563

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestMobStoreCompaction

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/Dockerfile
GITHUB PR	#223
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 416cd96bafe1 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `67c937f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/testReport/
Max. process+thread count	5049 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java

Apache9 · 2019-05-14T02:52:42Z

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java

+  }
+
+  private static LocalDate toLocalDate(long millisecond) {
+    return Instant.ofEpochMilli(millisecond).atZone(ZoneId.systemDefault()).toLocalDate();


Do we retain the same behavior with the old code? By default Date will use the system default time zone?

Yes, the Date class just use the JVM timezone

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java

Apache-HBase · 2019-05-20T10:15:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	21	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	250	master passed
+1	compile	54	master passed
+1	checkstyle	69	master passed
+1	shadedjars	260	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	195	master passed
+1	javadoc	29	master passed
		_ Patch Compile Tests _
+1	mvninstall	227	the patch passed
+1	compile	50	the patch passed
+1	javac	50	the patch passed
-1	checkstyle	66	hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	953	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1	findbugs	136	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
-1	unit	1616	hbase-server in the patch failed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		4313

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestRegionCoprocessorHost
	TEST-null
	hadoop.hbase.coprocessor.TestCoprocessorInterface

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/Dockerfile
GITHUB PR	#223
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d54f204ee408 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `c80f2ad`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/testReport/
Max. process+thread count	652 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-20T12:19:00Z

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java

@@ -1,5 +1,5 @@
 /**
- *
+ * 


whitespace:end of line

Apache-HBase · 2019-05-20T12:19:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	224	master passed
+1	compile	55	master passed
+1	checkstyle	66	master passed
+1	shadedjars	253	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	204	master passed
+1	javadoc	29	master passed
		_ Patch Compile Tests _
+1	mvninstall	231	the patch passed
+1	compile	50	the patch passed
+1	javac	50	the patch passed
-1	checkstyle	65	hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedjars	250	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	947	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1	findbugs	215	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
-1	unit	8432	hbase-server in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		11150

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestMobStoreCompaction

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/Dockerfile
GITHUB PR	#223
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 695f37518881 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `c80f2ad`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/testReport/
Max. process+thread count	4709 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-20T12:41:12Z

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java

@@ -1,5 +1,5 @@
 /**
- *
+ * 


whitespace:end of line

Apache-HBase · 2019-05-20T12:41:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	22	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 4 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	307	master passed
+1	compile	63	master passed
+1	checkstyle	82	master passed
+1	shadedjars	290	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	216	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	253	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
-1	checkstyle	77	hbase-server: The patch generated 87 new + 41 unchanged - 25 fixed = 128 total (was 66)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1052	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1	findbugs	227	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
-1	unit	8580	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		13525

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestMobStoreCompaction

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/Dockerfile
GITHUB PR	#223
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 27cac622a15d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `c80f2ad`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/testReport/
Max. process+thread count	4897 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-11T00:42:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	5	#223 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#223
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-223/8/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack · 2019-06-24T18:36:46Z

Any chance of addressing the conflicts? Thanks.

Apache9 · 2019-07-24T06:13:04Z

Close since the PR is stale and can not be merged. Feel free to reopen.

ArthurSXL8 · 2019-07-24T07:54:09Z

Sorry, I am a little busy during last days, will continue. So reopen it.

Apache9 · 2019-07-24T08:02:27Z

You can reopen when you have time to prepare a new patch.

Apache9 requested changes May 14, 2019

View reviewed changes

HBASE-22368 Use LocalDate instead of Date for MobUtil class

5cc1b40

Apache-HBase reviewed May 20, 2019

View reviewed changes

xujunhong added 2 commits May 22, 2019 05:13

fix unit failure and format

0408d79

fix format error

c5ca597

Apache9 closed this Jul 24, 2019

@@ @@ -1,5 +1,5 @@ @@
               /**
-               *
+               *

HBASE-22368 Use LocalDate instead of Date for MobUtil class #223

HBASE-22368 Use LocalDate instead of Date for MobUtil class #223

Uh oh!

Conversation

ArthurSXL8 commented May 7, 2019

Uh oh!

Apache-HBase commented May 7, 2019

Uh oh!

Uh oh!

Uh oh!

Apache9 May 14, 2019

Choose a reason for hiding this comment

Uh oh!

ArthurSXL8 May 20, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented May 20, 2019

Uh oh!

Apache-HBase May 20, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 20, 2019

Uh oh!

Apache-HBase May 20, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 20, 2019

Uh oh!

Apache-HBase commented Jun 11, 2019

Uh oh!

saintstack commented Jun 24, 2019

Uh oh!

Apache9 commented Jul 24, 2019

Uh oh!

ArthurSXL8 commented Jul 24, 2019

Uh oh!

Apache9 commented Jul 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants