HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… based on hbase.rpc.rows.warning.threshold
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Jul 23, 2020
| * Default value of {@link #BATCH_ROWS_THRESHOLD_NAME} | ||
| */ | ||
| public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000; | ||
|
|
Contributor
There was a problem hiding this comment.
Why the move? HConstants is often considered an anti-pattern; better to have constants beside where they are used?
Contributor
Author
There was a problem hiding this comment.
We want RsRpcServices as well as ReplicationSink both to use these constants. Would you still recommend having duplicate copies?
Contributor
There was a problem hiding this comment.
Ok. Two very disparate contexts. This is probably only case for HConstants.
| * @throws IOException thrown when HDFS goes bad or bad file name | ||
| */ | ||
| public ReplicationSink(Configuration conf, Stoppable stopper) | ||
| public ReplicationSink(Configuration conf) |
Contributor
There was a problem hiding this comment.
Is the Stoppable unused? Usually its a chain for a Service to pull on when it meets a condition it can't deal with... one that is so bad it wants to stop the process.
Contributor
Author
There was a problem hiding this comment.
Agree for stoppable usage, but here it is anyways unused :(
| batchRows = Collections.singletonList(rows); | ||
| } | ||
| futures.addAll(batchRows.stream().map(table::batchAll).collect(Collectors.toList())); | ||
| } |
Contributor
There was a problem hiding this comment.
For the edits that are beyond the limit, they get handled in next batch?
Contributor
Author
There was a problem hiding this comment.
That's true, they are handled in next batch.
Contributor
Author
There was a problem hiding this comment.
UT testLargeEditsPutDelete() as part of this PR will always ensure that this is handled.
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
added a commit
to virajjasani/hbase
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold Closes apache#2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
to virajjasani/hbase
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold Closes apache#2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
to virajjasani/hbase
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold Closes apache#2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
to virajjasani/hbase
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold Closes apache#2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
to virajjasani/hbase
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold Closes apache#2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold (#2136) Closes #2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 24, 2020
…n based on hbase.rpc.rows.warning.threshold (#2137) Closes #2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 27, 2020
…n based on hbase.rpc.rows.warning.threshold (#2139) Closes #2127 Signed-off-by: stack <[email protected]>
virajjasani
added a commit
that referenced
this pull request
Jul 27, 2020
…n based on hbase.rpc.rows.warning.threshold (#2146) Closes #2127 Signed-off-by: stack <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…n based on hbase.rpc.rows.warning.threshold (apache#2136) Closes apache#2127 Signed-off-by: stack <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…n based on hbase.rpc.rows.warning.threshold (apache#2139) Closes apache#2127 Signed-off-by: stack <[email protected]> (cherry picked from commit 603d2b6) Change-Id: I27416e5ee65bc2cbcb776e7f83487cb2c06e147a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.