HBASE-24743 Reject to add a peer which replicate to itself earlier #2124

infraio · 2020-07-23T04:11:03Z

No description provided.

infraio · 2020-07-23T04:11:17Z

PR for branch-2.

Apache-HBase · 2020-07-23T04:58:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 50s	branch-2 passed
+1 💚	checkstyle	1m 27s	branch-2 passed
+1 💚	spotbugs	2m 8s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	checkstyle	1m 24s	the patch passed
-0 ⚠️	rubocop	0m 6s	The patch generated 60 new + 295 unchanged - 16 fixed = 355 total (was 311)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		38m 43s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2124
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname	Linux df794d950834 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ce4e692`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-23T08:41:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	branch-2 passed
+1 💚	compile	1m 35s	branch-2 passed
+1 💚	shadedjars	6m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 32s	the patch passed
+1 💚	javac	1m 32s	the patch passed
+1 💚	shadedjars	6m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	the patch passed
		_ Other Tests _
+1 💚	unit	223m 33s	hbase-server in the patch passed.
-1 ❌	unit	7m 8s	hbase-shell in the patch failed.
		261m 21s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#2124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 00d68a21d13d 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ce4e692`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/testReport/
Max. process+thread count	2534 (vs. ulimit of 12500)
modules	C: hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-23T12:03:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 15s	branch-2 passed
+1 💚	checkstyle	1m 27s	branch-2 passed
+1 💚	spotbugs	2m 6s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	checkstyle	1m 27s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 62 new + 294 unchanged - 17 fixed = 356 total (was 311)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		37m 40s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2124
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop
uname	Linux 3c2c145f9b15 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ce4e692`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-23T14:37:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 30s	branch-2 passed
+1 💚	compile	1m 18s	branch-2 passed
+1 💚	shadedjars	5m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
+1 💚	shadedjars	5m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	151m 24s	hbase-server in the patch passed.
+1 💚	unit	7m 28s	hbase-shell in the patch passed.
		183m 54s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#2124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf99393fcc77 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ce4e692`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/testReport/
Max. process+thread count	3431 (vs. ulimit of 12500)
modules	C: hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-23T14:40:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 18s	branch-2 passed
+1 💚	compile	1m 32s	branch-2 passed
+1 💚	shadedjars	5m 54s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in branch-2 failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 21s	the patch passed
+1 💚	compile	1m 52s	the patch passed
+1 💚	javac	1m 52s	the patch passed
+1 💚	shadedjars	8m 10s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 50s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	141m 20s	hbase-server in the patch passed.
+1 💚	unit	7m 8s	hbase-shell in the patch passed.
		180m 22s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2124
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 61ffb573f6e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ce4e692`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/testReport/
Max. process+thread count	4167 (vs. ulimit of 12500)
modules	C: hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2124/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

infraio · 2020-07-24T00:08:54Z

Ok. All ut passed.

…pache#2124) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

…cation plugin: 1) Revert "HBASE-24743 Reject to add a peer which replicate to itself earlier (apache#2124)" This reverts commit 70ab0dc. 2)Revert "HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers. (apache#2284)" This reverts commit 7df1b92. Change-Id: I8d5e66a9073caf61e744a19425c350c49f4b7072

…pache#209) * CDPD-71667: Revert "HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers. (apache#2284)" This reverts commit 7df1b92. Change-Id: I2b4570a3ab1bca6c573c669a54ef67008438bd95 * CDPD-71667: Revert "HBASE-24743 Reject to add a peer which replicate to itself earlier (apache#2124)" This reverts commit 70ab0dc. Change-Id: I6d508ff3aacf2d48e00f903afe7bca21d34f3247 --------- Co-authored-by: Wellington Ramos Chevreuil <[email protected]>

HBASE-24743 Reject to add a peer which replicate to itself earlier

7165ea7

infraio force-pushed the HBASE-24743-branch-2 branch from 484ad36 to 7165ea7 Compare July 23, 2020 09:18

wchevreuil approved these changes Jul 23, 2020

View reviewed changes

infraio merged commit 70ab0dc into apache:branch-2 Jul 24, 2020

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24743 Reject to add a peer which replicate to itself earlier (a…

8a04c0e

…pache#2124) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24743 Reject to add a peer which replicate to itself earlier #2124

HBASE-24743 Reject to add a peer which replicate to itself earlier #2124

Uh oh!

infraio commented Jul 23, 2020

Uh oh!

infraio commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

infraio commented Jul 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-24743 Reject to add a peer which replicate to itself earlier #2124

HBASE-24743 Reject to add a peer which replicate to itself earlier #2124

Uh oh!

Conversation

infraio commented Jul 23, 2020

Uh oh!

infraio commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

Apache-HBase commented Jul 23, 2020

Uh oh!

infraio commented Jul 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants