-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-24696 Include JVM information on Web UI under "Software Attributes" #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, looks good otherwise.
| * Return the current JVM version information. | ||
| */ | ||
| public static String getVersion() { | ||
| return System.getProperty("java.vm.vendor", "UsNKNOWN_VM_VENDOR") + ' ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo UNKNOWN_VM_VENDOR ?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| /** | ||
| * Return the current JVM version information. | ||
| */ | ||
| public static String getVersion() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the javadoc in the class header, this is a repurposing of the existing class. I think it's fine to put this method into this class, as the name and location of the class seem like a reasonable place to find this information. Can you update the javadoc on the class header according to the expanded scope of the class?
Otherwise, +1.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…tes" Closes #2087 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…tes" Closes #2087 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…tes" Closes apache#2087 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
https://issues.apache.org/jira/browse/HBASE-24696
@ndimiduk