Skip to content

HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er… #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pankaj72981 merged 1 commit into from
Sep 4, 2020
Merged

HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er… #2074

pankaj72981 merged 1 commit into from
Sep 4, 2020

Conversation

@arshadmohammad
Copy link
Contributor

@arshadmohammad arshadmohammad commented Jul 15, 2020

…ror message

@Apache-HBase
Copy link

Apache-HBase commented Jul 15, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 46s branch-2 passed
+1 💚 compile 0m 23s branch-2 passed
+1 💚 shadedjars 4m 58s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
+1 💚 unit 3m 7s hbase-rsgroup in the patch passed.
23m 49s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests javac javadoc unit shadedjars compile
uname Linux d2baaaf50ea8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad826a4
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count 3580 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 15, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 34s branch-2 passed
+1 💚 compile 0m 29s branch-2 passed
+1 💚 shadedjars 6m 5s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-rsgroup in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 0m 28s the patch passed
+1 💚 javac 0m 28s the patch passed
+1 💚 shadedjars 6m 39s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 23s hbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚 unit 3m 1s hbase-rsgroup in the patch passed.
28m 5s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests javac javadoc unit shadedjars compile
uname Linux 341361684e60 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad826a4
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count 3862 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 15, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 18s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 3s branch-2 passed
+1 💚 checkstyle 0m 13s branch-2 passed
+1 💚 spotbugs 0m 42s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 35s the patch passed
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 45s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 50s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
31m 42s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 842528546d1e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad826a4
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@arshadmohammad
Copy link
Contributor Author

arshadmohammad commented Jul 20, 2020

@pankaj72981 can you please review it

@pankaj72981 pankaj72981 requested a review from Reidddddd July 20, 2020 14:17
pankaj72981
pankaj72981 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@pankaj72981 pankaj72981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@Apache-HBase
Copy link

Apache-HBase commented Aug 10, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 58s branch-2 passed
+1 💚 compile 0m 23s branch-2 passed
+1 💚 shadedjars 5m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 32s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 shadedjars 5m 27s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s the patch passed
_ Other Tests _
+1 💚 unit 4m 41s hbase-rsgroup in the patch passed.
26m 39s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests javac javadoc unit shadedjars compile
uname Linux 058ae7021c8e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cee7431
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/testReport/
Max. process+thread count 2443 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 10, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 5m 35s branch-2 passed
+1 💚 checkstyle 0m 16s branch-2 passed
+1 💚 spotbugs 0m 55s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 35s the patch passed
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 21s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 58s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
40m 48s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 63f59b2b453e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / cee7431
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 31, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 56s branch-2 passed
+1 💚 compile 0m 23s branch-2 passed
+1 💚 shadedjars 6m 25s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 shadedjars 6m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s the patch passed
_ Other Tests _
+1 💚 unit 4m 11s hbase-rsgroup in the patch passed.
28m 5s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests javac javadoc unit shadedjars compile
uname Linux fc7809abfa39 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad17705
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count 2300 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 31, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 59s branch-2 passed
+1 💚 checkstyle 0m 13s branch-2 passed
+1 💚 spotbugs 0m 43s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 checkstyle 0m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 26s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 50s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
29m 53s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux ab2bab78e8e9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad17705
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Aug 31, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 57s branch-2 passed
+1 💚 compile 0m 31s branch-2 passed
+1 💚 shadedjars 7m 24s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 28s hbase-rsgroup in branch-2 failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 18s the patch passed
+1 💚 compile 0m 31s the patch passed
+1 💚 javac 0m 31s the patch passed
+1 💚 shadedjars 7m 9s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚 unit 3m 11s hbase-rsgroup in the patch passed.
30m 36s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2074
JIRA Issue HBASE-24719
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0fd78abfa35f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / ad17705
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/testReport/
Max. process+thread count 3167 (vs. ulimit of 12500)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2074/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@arshadmohammad
Copy link
Contributor Author

arshadmohammad commented Aug 31, 2020

This is pending for commit from long time. Can someone please commit it.

@pankaj72981 pankaj72981 closed this Sep 4, 2020
@pankaj72981 pankaj72981 reopened this Sep 4, 2020
@pankaj72981 pankaj72981 merged commit aac21ae into apache:branch-2 Sep 4, 2020
asfgit pushed a commit that referenced this pull request Sep 4, 2020
@arshadmohammad @pankaj72981
HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…
8218087 
…ror message (#2074)

Signed-off-by: Pankaj Kumar<[email protected]>
(cherry picked from commit aac21ae)
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@arshadmohammad @clarax
HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…
2cc9853 
…ror message (apache#2074)

Signed-off-by: Pankaj Kumar<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj72981 pankaj72981 pankaj72981 approved these changes

@Reidddddd Reidddddd Awaiting requested review from Reidddddd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arshadmohammad @Apache-HBase @pankaj72981