HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2062

huaxiangsun · 2020-07-14T00:33:28Z

…eplicas (i.e, replica regions are not created)

Apache-HBase · 2020-07-14T01:12:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	checkstyle	1m 9s	master passed
+1 💚	spotbugs	1m 56s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 22s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 6 new + 183 unchanged - 0 fixed = 189 total (was 183)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 9s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		32m 30s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 35679cb7b3e1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T03:17:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	5m 45s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	129m 42s	hbase-server in the patch passed.
		156m 50s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3526a14bedcc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/testReport/
Max. process+thread count	4627 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T03:29:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 23s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	6m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	6m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	141m 28s	hbase-server in the patch passed.
		168m 54s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 534167cdce1b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/testReport/
Max. process+thread count	5095 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

A couple of nits, looks good overall.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java

…eplicas (i.e, replica regions are not created)

huaxiangsun · 2020-07-14T17:54:44Z

Updated based on the comments.

Apache-HBase · 2020-07-14T18:17:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	checkstyle	1m 37s	master passed
+1 💚	spotbugs	2m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
-0 ⚠️	checkstyle	1m 11s	hbase-server: The patch generated 5 new + 192 unchanged - 0 fixed = 197 total (was 192)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		36m 45s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux efd55e27e012 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ee226de`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-07-14T20:40:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 18s	master passed
+1 💚	compile	1m 38s	master passed
+1 💚	shadedjars	6m 4s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 29s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	1m 34s	the patch passed
+1 💚	javac	1m 34s	the patch passed
+1 💚	shadedjars	6m 4s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 48s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 24s	hbase-client in the patch passed.
+1 💚	unit	149m 5s	hbase-server in the patch passed.
		180m 3s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux daae870bcec7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ee226de`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/testReport/
Max. process+thread count	4226 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-14T20:48:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	1m 23s	master passed
+1 💚	shadedjars	5m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 6s	hbase-client in the patch passed.
+1 💚	unit	160m 19s	hbase-server in the patch passed.
		188m 4s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2dad1fac49ee 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ee226de`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/testReport/
Max. process+thread count	3750 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…eplicas (i.e, replica regions are not created) (apache#2062) Signed-off-by: Viraj Jasani <[email protected]>

…eplicas (i.e, replica regions are not created) (#2062) (#2068) Signed-off-by: Viraj Jasani <[email protected]>

…eplicas (i.e, replica regions are not created) (#2062) (#2067) Signed-off-by: Viraj Jasani <[email protected]>

…eplicas (i.e, replica regions are not created) (apache#2062) (apache#2068) Signed-off-by: Viraj Jasani <[email protected]>

virajjasani reviewed Jul 14, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Outdated Show resolved Hide resolved

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Outdated Show resolved Hide resolved

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

f106480

…eplicas (i.e, replica regions are not created)

huaxiangsun force-pushed the master.HBASE-24705 branch from 0ccc115 to f106480 Compare July 14, 2020 17:35

virajjasani approved these changes Jul 14, 2020

View reviewed changes

huaxiangsun merged commit 1360bee into apache:master Jul 14, 2020

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jul 15, 2020

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

f3ffed0

…eplicas (i.e, replica regions are not created) (apache#2062) Signed-off-by: Viraj Jasani <[email protected]>

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jul 15, 2020

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

179cf68

…eplicas (i.e, replica regions are not created) (apache#2062) Signed-off-by: Viraj Jasani <[email protected]>

This was referenced Jul 15, 2020

Backport: HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2067

Merged

Backport: HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2068

Merged

huaxiangsun added a commit that referenced this pull request Jul 15, 2020

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

0e45e37

…eplicas (i.e, replica regions are not created) (#2062) (#2068) Signed-off-by: Viraj Jasani <[email protected]>

huaxiangsun added a commit that referenced this pull request Jul 15, 2020

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

c73b2b9

…eplicas (i.e, replica regions are not created) (#2062) (#2067) Signed-off-by: Viraj Jasani <[email protected]>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…

584eb26

…eplicas (i.e, replica regions are not created) (apache#2062) (apache#2068) Signed-off-by: Viraj Jasani <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2062

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2062

Uh oh!

huaxiangsun commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Uh oh!

Uh oh!

huaxiangsun commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2062

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… #2062

Uh oh!

Conversation

huaxiangsun commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

huaxiangsun commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Apache-HBase commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants