Skip to content

HBASE-24404 Support flush a single column family of region #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wchevreuil merged 4 commits into from
Jul 10, 2020
Merged

HBASE-24404 Support flush a single column family of region #2032

wchevreuil merged 4 commits into from
Jul 10, 2020

Conversation

@bsglz
Copy link
Contributor

@bsglz bsglz commented Jul 7, 2020

No description provided.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s master passed
+1 💚 checkstyle 2m 0s master passed
+1 💚 spotbugs 6m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 40s root in the patch failed.
-0 ⚠️ checkstyle 0m 27s hbase-client: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️ rubocop 0m 9s The patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 2m 40s The patch causes 14 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 5m 29s The patch causes 14 errors with Hadoop v3.2.1.
+1 💚 hbaseprotoc 2m 17s the patch passed
+1 💚 spotbugs 6m 55s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
38m 52s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2032
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname Linux f9027f5e5374 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

@bsglz
Copy link
Contributor Author

bsglz commented Jul 7, 2020 •
edited
Loading

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira.
BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way?

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s master passed
+1 💚 compile 2m 54s master passed
+1 💚 shadedjars 5m 48s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in master failed.
-0 ⚠️ javadoc 0m 39s hbase-server in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 48s root in the patch failed.
+1 💚 compile 2m 50s the patch passed
+1 💚 javac 2m 50s the patch passed
+1 💚 shadedjars 5m 47s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 39s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 0m 58s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 10s hbase-client in the patch passed.
+1 💚 unit 132m 0s hbase-server in the patch passed.
+1 💚 unit 7m 19s hbase-shell in the patch passed.
173m 31s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux e1e16178f6a7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/testReport/
Max. process+thread count 4259 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 4m 5s master passed
+1 💚 compile 2m 41s master passed
+1 💚 shadedjars 6m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 47s root in the patch failed.
+1 💚 compile 2m 37s the patch passed
+1 💚 javac 2m 37s the patch passed
+1 💚 shadedjars 6m 20s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 0m 51s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 17s hbase-client in the patch passed.
+1 💚 unit 204m 42s hbase-server in the patch passed.
+1 💚 unit 8m 18s hbase-shell in the patch passed.
247m 53s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9ee445d882a7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 1.8.0_232
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/testReport/
Max. process+thread count 3059 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 7s master passed
+1 💚 checkstyle 2m 59s master passed
+1 💚 spotbugs 8m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
-0 ⚠️ checkstyle 0m 29s hbase-client: The patch generated 6 new + 107 unchanged - 0 fixed = 113 total (was 107)
-0 ⚠️ rubocop 0m 11s The patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 28s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 2m 59s the patch passed
+1 💚 spotbugs 9m 8s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
58m 40s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2032
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname Linux e56f43de8cdc 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s master passed
+1 💚 compile 3m 27s master passed
+1 💚 shadedjars 5m 48s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in master failed.
-0 ⚠️ javadoc 0m 40s hbase-server in master failed.
-0 ⚠️ javadoc 0m 52s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 3m 28s the patch passed
+1 💚 javac 3m 28s the patch passed
+1 💚 shadedjars 5m 49s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 26s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 41s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 57s hbase-thrift in the patch failed.
_ Other Tests _
+1 💚 unit 1m 0s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 14s hbase-client in the patch passed.
+1 💚 unit 132m 49s hbase-server in the patch passed.
+1 💚 unit 4m 50s hbase-thrift in the patch passed.
+1 💚 unit 7m 23s hbase-shell in the patch passed.
182m 9s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux 809f02984641 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/testReport/
Max. process+thread count 4496 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 3m 37s master passed
+1 💚 compile 2m 58s master passed
+1 💚 shadedjars 5m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 27s the patch passed
+1 💚 compile 2m 56s the patch passed
+1 💚 javac 2m 56s the patch passed
+1 💚 shadedjars 5m 35s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 57s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 7s hbase-client in the patch passed.
+1 💚 unit 137m 7s hbase-server in the patch passed.
+1 💚 unit 4m 29s hbase-thrift in the patch passed.
+1 💚 unit 7m 15s hbase-shell in the patch passed.
182m 39s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5d557a1b2e8a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/testReport/
Max. process+thread count 4321 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 54s master passed
+1 💚 checkstyle 2m 46s master passed
+1 💚 spotbugs 7m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 checkstyle 2m 43s the patch passed
-0 ⚠️ rubocop 0m 11s The patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 20s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 2m 47s the patch passed
+1 💚 spotbugs 8m 38s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
55m 47s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2032
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname Linux 72273f24a1a7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 22s master passed
+1 💚 compile 2m 57s master passed
+1 💚 shadedjars 5m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 59s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 23s the patch passed
+1 💚 compile 2m 55s the patch passed
+1 💚 javac 2m 55s the patch passed
+1 💚 shadedjars 5m 30s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 59s the patch passed
_ Other Tests _
+1 💚 unit 0m 44s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 5s hbase-client in the patch passed.
+1 💚 unit 137m 26s hbase-server in the patch passed.
+1 💚 unit 4m 31s hbase-thrift in the patch passed.
+1 💚 unit 7m 12s hbase-shell in the patch passed.
182m 17s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux 65ec6fc217b1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/testReport/
Max. process+thread count 4282 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 7, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 16s master passed
+1 💚 compile 3m 29s master passed
+1 💚 shadedjars 6m 5s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-client in master failed.
-0 ⚠️ javadoc 0m 39s hbase-server in master failed.
-0 ⚠️ javadoc 0m 51s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 0s the patch passed
+1 💚 compile 3m 25s the patch passed
+1 💚 javac 3m 26s the patch passed
+1 💚 shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 41s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 49s hbase-thrift in the patch failed.
_ Other Tests _
+1 💚 unit 0m 57s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 8s hbase-client in the patch passed.
+1 💚 unit 132m 55s hbase-server in the patch passed.
+1 💚 unit 4m 44s hbase-thrift in the patch passed.
+1 💚 unit 7m 22s hbase-shell in the patch passed.
182m 34s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2032
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9c40ff864ec4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 34e807a
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/testReport/
Max. process+thread count 3926 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor

wchevreuil commented Jul 8, 2020 •
edited
Loading

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira.
BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way?

Indeed, it's more complex than I originally thought. Let's keep discussing it on the other jira. I think this one is good to go, after fixing the latest javadoc issues.

@bsglz
Copy link
Contributor Author

bsglz commented Jul 9, 2020 •
edited
Loading

The javadoc issues also exist in master, is this a bug of jdk11? See https://bugs.openjdk.java.net/browse/JDK-8212233.

There is a workaround in project commons-pool, can we do as same way?
https://github.com/apache/commons-pool/blob/master/pom.xml

    <profile>
      <id>java11+</id>
      <activation>
        <jdk>[11,)</jdk>
      </activation>
      <properties>
        <!-- Workaround for https://bugs.openjdk.java.net/browse/JDK-8212233
             which causes javadoc to fail with "javadoc: error - The code being documented uses modules
             but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module."  -->
        <maven.javadoc.skip>true</maven.javadoc.skip>
      </properties>
    </profile>

Thanks. @wchevreuil

@bsglz bsglz requested a review from wchevreuil July 10, 2020 02:42
@wchevreuil
Copy link
Contributor

wchevreuil commented Jul 10, 2020

The javadoc issues also exist in master, is this a bug of jdk11? See https://bugs.openjdk.java.net/browse/JDK-8212233.

There is a workaround in project commons-pool, can we do as same way?
https://github.com/apache/commons-pool/blob/master/pom.xml

    <profile>
      <id>java11+</id>
      <activation>
        <jdk>[11,)</jdk>
      </activation>
      <properties>
        <!-- Workaround for https://bugs.openjdk.java.net/browse/JDK-8212233
             which causes javadoc to fail with "javadoc: error - The code being documented uses modules
             but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module."  -->
        <maven.javadoc.skip>true</maven.javadoc.skip>
      </properties>
    </profile>

Thanks. @wchevreuil

No, let's leave as it is. Am going to merge it now.

@wchevreuil wchevreuil merged commit 724f047 into apache:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsglz @Apache-HBase @wchevreuil