HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… #2020

infraio · 2020-07-06T03:03:20Z

…o ReplicationSourceManager

Apache-HBase · 2020-07-06T03:44:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	4m 22s	HBASE-24666 passed
+1 💚	checkstyle	1m 19s	HBASE-24666 passed
+1 💚	spotbugs	2m 15s	HBASE-24666 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s	the patch passed
-0 ⚠️	checkstyle	1m 17s	hbase-server: The patch generated 10 new + 4 unchanged - 0 fixed = 14 total (was 4)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 37s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		39m 6s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux e6d9d63ca70d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-06T05:50:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	4m 18s	HBASE-24666 passed
+1 💚	compile	1m 3s	HBASE-24666 passed
+1 💚	shadedjars	5m 44s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in HBASE-24666 failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	5m 47s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 39s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	139m 31s	hbase-server in the patch passed.
		165m 19s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f82d59bc50d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/testReport/
Max. process+thread count	4408 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-06T06:56:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	4m 20s	HBASE-24666 passed
+1 💚	compile	1m 2s	HBASE-24666 passed
+1 💚	shadedjars	6m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	HBASE-24666 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	6m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	204m 11s	hbase-server in the patch passed.
		231m 36s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cfe499f5932b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/testReport/
Max. process+thread count	3285 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Makes sense to be in ReplicationSourceManager only. Should go on master branch?

…o ReplicationSourceManager

Apache-HBase · 2020-07-08T02:10:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	3m 52s	HBASE-24666 passed
+1 💚	checkstyle	1m 5s	HBASE-24666 passed
+1 💚	spotbugs	2m 2s	HBASE-24666 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	checkstyle	1m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 18s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		35m 19s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux f42ec51d49fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-08T04:26:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	3m 53s	HBASE-24666 passed
+1 💚	compile	0m 56s	HBASE-24666 passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-24666 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	5m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	146m 47s	hbase-server in the patch passed.
		170m 53s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 31653c0b0a3f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/testReport/
Max. process+thread count	3883 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-08T05:35:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24666 Compile Tests _
+1 💚	mvninstall	4m 44s	HBASE-24666 passed
+1 💚	compile	1m 8s	HBASE-24666 passed
+1 💚	shadedjars	6m 25s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in HBASE-24666 failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	6m 26s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	211m 31s	hbase-server in the patch passed.
		240m 37s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ec4b4acc72db 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24666 / `fe2ae80`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/testReport/
Max. process+thread count	3289 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

infraio · 2020-07-08T06:27:58Z

Makes sense to be in ReplicationSourceManager only. Should go on master branch?

Yes. Now only foucs on feature branch. I thought we can backport it in future.

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

…o ReplicationSourceManager (apache#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil approved these changes Jul 7, 2020

View reviewed changes

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

aa2b5c3

…o ReplicationSourceManager

infraio force-pushed the HBASE-24682 branch from d6e60cd to aa2b5c3 Compare July 8, 2020 01:26

infraio added the enhancement label Jul 8, 2020

infraio merged commit 8587fb1 into apache:HBASE-24666 Jul 8, 2020

asfgit pushed a commit that referenced this pull request Jul 8, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

c294971

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Jul 13, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

1005379

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Jul 21, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

bb9cae1

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Aug 10, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

d45171f

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

57bafbb

…o ReplicationSourceManager (apache#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 14, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

8e1bf74

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 23, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

f54d2ab

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 24, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

9c8d54b

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

infraio added a commit that referenced this pull request Sep 26, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

1d4584f

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 29, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

c315e68

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

asfgit pushed a commit that referenced this pull request Oct 22, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

7a41a3e

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

infraio added a commit that referenced this pull request Nov 9, 2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

ee34412

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

ddupg pushed a commit that referenced this pull request Feb 23, 2021

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

a62a4b1

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

ddupg pushed a commit that referenced this pull request Jul 9, 2021

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

0c061bc

…o ReplicationSourceManager (#2020) Signed-off-by: Wellington Chevreuil <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… #2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… #2020

Uh oh!

infraio commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

wchevreuil left a comment

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

infraio commented Jul 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… #2020

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… #2020

Uh oh!

Conversation

infraio commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

Apache-HBase commented Jul 6, 2020

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

Apache-HBase commented Jul 8, 2020

Uh oh!

infraio commented Jul 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants