Skip to content

HBASE-24422: Remove hbase-native-client code from the master branch #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bharathv merged 1 commit into from
May 24, 2020
Merged

HBASE-24422: Remove hbase-native-client code from the master branch #1766

bharathv merged 1 commit into from
May 24, 2020

Conversation

@bharathv
Copy link
Contributor

@bharathv bharathv commented May 24, 2020

Per recent discussions in the slack channel, there is not much value
in having this code in the master branch. This code has it's dedicated
git repo at https://github.com/apache/hbase-native-client.

It was already removed from branch-1 (HBASE-19419) and branch-2
(HBASE-19176)

@Apache-HBase
Copy link

Apache-HBase commented May 24, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 shellcheck 0m 1s The patch generated 0 new + 1 unchanged - 40 fixed = 1 total (was 41)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
2m 7s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1766
JIRA Issue HBASE-24422
Optional Tests dupname asflicense shellcheck shelldocs cc markdownlint golang
uname Linux ac28087ef7c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c303f9d
Max. process+thread count 51 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented May 24, 2020

Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.

However, totally agree we're overdue on removing this

virajjasani
virajjasani approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

Apache-HBase commented May 24, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 24s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 1s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 49s the patch passed
_ Other Tests _
+1 💚 unit 258m 4s root in the patch passed.
270m 27s
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1766
JIRA Issue HBASE-24422
Optional Tests unit
uname Linux d729380f12af 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c303f9d
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/testReport/
Max. process+thread count 5012 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@bharathv
HBASE-24422: Remove hbase-native-client code from the master branch
5ebc2b7 
There is not much value in having this code in the master branch.
This code has it's dedicated git repo at
https://github.com/apache/hbase-native-client.

It was already removed from branch-1 (HBASE-19419) and branch-2
(HBASE-19176)
@bharathv
Copy link
Contributor Author

bharathv commented May 24, 2020

Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.

Fixed the commit message to remove this part.

@bharathv bharathv merged commit 2382f90 into apache:master May 24, 2020
@bharathv bharathv deleted the HBASE-24422 branch May 24, 2020 23:20
@Apache-HBase
Copy link

Apache-HBase commented May 24, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 3s #1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #1766
JIRA Issue HBASE-24422
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

2 similar comments
@Apache-HBase
Copy link

Apache-HBase commented May 24, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 3s #1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #1766
JIRA Issue HBASE-24422
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented May 24, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 3s #1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #1766
JIRA Issue HBASE-24422
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busbey busbey busbey approved these changes

@HorizonNet HorizonNet HorizonNet approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bharathv @Apache-HBase @busbey @HorizonNet @virajjasani