HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
symat
reviewed
Apr 8, 2020
Contributor
symat
left a comment
symat
left a comment
There was a problem hiding this comment.
nice PR! We are building HBase (and many other components now) with ZooKeeper 3.5.x, and it works very well with the whole stack. For us the SSL support in ZooKeeper 3.5 was also very important. I think ZooKeeper 3.4 will be announced to be EOL soon, the details are just now discussed on the dev ZooKeeper mailing list.
I compared your PR with our internal changes we had to make to be ZooKeeper 3.5 compatible. I found only a single issue, see my comment below.
| <thrift.version>0.12.0</thrift.version> | ||
| <zookeeper.version>3.4.14</zookeeper.version> | ||
| <!-- What ZooKeeper 3.4.x depends on and nothing more --> | ||
| <zookeeper.version>3.5.7</zookeeper.version> |
Contributor
There was a problem hiding this comment.
should we also update the jline version? I think it was added because of zookeeper, see https://issues.apache.org/jira/browse/HBASE-20108
zookeeper 3.5.7 is using jline 2.11
however, if we increment the JLine version, then the assembly:single maven target will fail, as the license part in JLine pom changed a bit (they named it 'The BSD License' instead of 'BSD License'). To make it work, we need to add a new supplement to supplemental-models.xml like:
<supplement>
<project>
<groupId>jline</groupId>
<artifactId>jline</artifactId>
<name>JLine</name>
<version>2.11</version>
<licenses>
<license>
<name>BSD License</name>
<url>http://www.opensource.org/licenses/bsd-license.php</url>
<distribution>repo</distribution>
</license>
</licenses>
</project>
</supplement>
Contributor
|
Trigger the build again to see if it could pass this time. And for the jline change, I'm fine with doing it here or in another issue. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
busbey
requested changes
Apr 8, 2020
Contributor
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
Please include the jline changes in this PR.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Can 3.5.7 client talk to a 3.4 ensemble and vice-versa? Are their compatibility issues? Would be good to note in release note for this JIRA. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
update apache hbase
francisjjf
commented
Apr 10, 2020
| // make sure none of regionserver threads is alive. | ||
| UTIL.waitFor(30_000, () -> | ||
| UTIL.getMiniHBaseCluster().getLiveRegionServerThreads().isEmpty()); | ||
| // Start up everything again |
Contributor
Author
There was a problem hiding this comment.
add a rs all down check here to make the testcase stable.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Apr 13, 2020
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
I have outstanding question above otherwise LGTM.
Contributor
|
Hi @saintstack , I just noticed your question on the jira, and saw you also asked here: yes, 3.5.7 client is able to communicate with an 3.4.x ensemble. But new features should not be used. |
saintstack
approved these changes
Apr 13, 2020
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
ddupg
pushed a commit
to ddupg/hbase
that referenced
this pull request
Apr 20, 2020
* HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 * HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 Co-authored-by: 姜建飞 10222269 <[email protected]> Signed-off-by: Mate Szalay-Beko <[email protected]> Signed-off-by: Norbert Kalmar <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.