HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone #1446

busbey · 2020-04-07T07:07:41Z

This is broken up into 3 commits that should be squashed before merging.

First refactor the MOB compaction tests so that they do more code reuse, so we can add our test(s) once and cover the various configuration options (tests should still pass after this commit)
Next add test(s) for when a snapshot clone happens to ensure we still properly can compact (the write amplification optimized tests will start to fail here)
Fix how we keep track of mob reference files so that we can tell where they ought to be in the filesystem even after a snapshot clone, essentially by aggregating at the hfile level the amount of information we have when resolving a given cell (tests should again pass)

…nd use that to find it later.

busbey · 2020-04-07T07:11:41Z

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java

+ */
+@SuppressWarnings("deprecation")
+@Category(LargeTests.class)
+public class TestMobCompactionWithDefaults {


This file is a rename of TestMobCompactionBase that's then combined with TestMobCompactionRegularMode.java. I'm not sure why the github UI doesn't show it as that. my local git client can see it.

busbey · 2020-04-07T21:57:28Z

the shaded jars failure is a problem introduced in HBASE-24801 / #1392. I believe the fix has since landed.

I restarted the QAbot

busbey · 2020-04-08T13:45:31Z

JDK8 unit test failure looks like an environment issue.

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java

Apache-HBase · 2020-04-08T15:16:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 14s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	2m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 18s	the patch passed
+1 💚	checkstyle	0m 27s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	1m 5s	hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 18s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	3m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		38m 18s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 3e81e755f6c3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c383bd1`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-08T17:21:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 20s	master passed
+1 💚	compile	1m 17s	master passed
+1 💚	shadedjars	4m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 10s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 16s	hbase-common in the patch passed.
-1 ❌	unit	134m 15s	hbase-server in the patch failed.
		163m 37s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux eaa5a105467d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c383bd1`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/testReport/
Max. process+thread count	3962 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-08T17:28:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 21s	master passed
+1 💚	compile	1m 32s	master passed
+1 💚	shadedjars	5m 26s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 20s	the patch passed
+1 💚	compile	1m 31s	the patch passed
+1 💚	javac	1m 31s	the patch passed
+1 💚	shadedjars	6m 14s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 20s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 51s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 46s	hbase-common in the patch passed.
-1 ❌	unit	134m 12s	hbase-server in the patch failed.
		169m 41s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4f8dc77888f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c383bd1`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/testReport/
Max. process+thread count	3612 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java

Apache-HBase · 2020-04-08T18:08:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 24s	master passed
+1 💚	checkstyle	1m 33s	master passed
+1 💚	spotbugs	2m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	checkstyle	0m 24s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	1m 6s	hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 30s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	3m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		38m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 858bb8dc805e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed83022`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey · 2020-04-08T18:20:00Z

unit test failures on latest qabot run all look like env issues on unrelated code.

esteban · 2020-04-08T19:07:25Z

+1 lgtm.

busbey · 2020-04-08T19:16:54Z

thanks for the review!

Apache-HBase · 2020-04-08T20:20:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 37s	master passed
+1 💚	compile	1m 56s	master passed
+1 💚	shadedjars	7m 14s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	hbase-common in master failed.
-0 ⚠️	javadoc	0m 49s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	8m 29s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
+1 💚	shadedjars	7m 11s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-common in the patch failed.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 38s	hbase-common in the patch passed.
+1 💚	unit	126m 57s	hbase-server in the patch passed.
		170m 24s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 42f65b77b233 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed83022`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/testReport/
Max. process+thread count	3970 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-08T21:20:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 39s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 48s	master passed
+1 💚	compile	1m 31s	master passed
+1 💚	shadedjars	5m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 56s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	5m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 41s	hbase-common in the patch passed.
+1 💚	unit	193m 42s	hbase-server in the patch passed.
		230m 48s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1446
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5c92a0dfc097 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed83022`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/testReport/
Max. process+thread count	3521 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…hot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]>

…hot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. (cherry picked from commit eb7df04) Change-Id: Ie3dc11f9cd5cd3b0ed39e260891d240a0e391d61 Signed-off-by: Esteban Gutierrez <[email protected]> Author: Sean Busbey Reason: Bug Ref: CDPD-10138

…hot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]>

…hot clone (#4617) * HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]> * spotless:apply to fix HBaseTestingUtility * Fix error-prone errors Signed-off-by: Esteban Gutierrez <[email protected]> Co-authored-by: Sean Busbey <[email protected]>

…hot clone (apache#4617) * HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]> * spotless:apply to fix HBaseTestingUtility * Fix error-prone errors Signed-off-by: Esteban Gutierrez <[email protected]> Co-authored-by: Sean Busbey <[email protected]>

…hot clone (#4617) (#4704) * HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]> * spotless:apply to fix HBaseTestingUtility * Fix error-prone errors Signed-off-by: Esteban Gutierrez <[email protected]> Co-authored-by: Sean Busbey <[email protected]> Signed-off-by: Esteban Gutierrez <[email protected]> Co-authored-by: Andrew Purtell <[email protected]> Co-authored-by: Sean Busbey <[email protected]>

…hot clone (apache#1446) * Reorganize MOB compaction tests for more reuse. * Add tests for mob compaction after snapshot clone operations * note the original table used to write a given mob hfile and use that to find it later. Signed-off-by: Esteban Gutierrez <[email protected]> This commit does not contain secrets Change-Id: I558daa648248789ac5f4ffd51967035618be6960

busbey added 3 commits April 7, 2020 02:03

HBASE-23723 Reorganize MOB compaction tests for more reuse.

1de5967

HBASE-23723 Add a test for mob compaction after a snapshot clone.

4ba9e30

HBASE-23723 note the original table used to write a given mob hfile a…

22508db

…nd use that to find it later.

busbey commented Apr 7, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

busbey commented Apr 8, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java Outdated Show resolved Hide resolved

HBASE-23723 checkstyle / javadoc cleanup courtesy qabot feedback.

3baa8e9

esteban reviewed Apr 8, 2020

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java Show resolved Hide resolved

esteban reviewed Apr 8, 2020

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java Show resolved Hide resolved

esteban reviewed Apr 8, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java Show resolved Hide resolved

esteban reviewed Apr 8, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreFlusher.java Outdated Show resolved Hide resolved

esteban reviewed Apr 8, 2020

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java Show resolved Hide resolved

busbey requested a review from esteban April 8, 2020 19:06

busbey merged commit eb7df04 into apache:master Apr 8, 2020

busbey deleted the HBASE-23723 branch April 8, 2020 19:16

huaxiangsun mentioned this pull request Aug 12, 2022

HBASE-23723 Ensure MOB compaction works in optimized mode after snaps… #4704

Merged

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone #1446

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone #1446

Uh oh!

Conversation

busbey commented Apr 7, 2020

Uh oh!

busbey Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

busbey commented Apr 7, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

busbey commented Apr 8, 2020

Uh oh!

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

busbey commented Apr 8, 2020

Uh oh!

esteban commented Apr 8, 2020

Uh oh!

busbey commented Apr 8, 2020

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

Apache-HBase commented Apr 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants