Skip to content

HBASE-24121 [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Reidddddd merged 4 commits into from
Apr 9, 2020
Merged

HBASE-24121 [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be #1439

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efc2e02
HBASE-24121 [Authorization] ServiceAuthorizationManager isn't dynamic…
Reidddddd Apr 6, 2020
02daa15
Address review comments
Reidddddd Apr 7, 2020
38881ae
LOG.info for refreshing policy file
Reidddddd Apr 9, 2020
bbadfdf
Hard code log info
Reidddddd Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.apache.hadoop.hbase.regionserver.RSRpcServices;
import org.apache.hadoop.hbase.regionserver.slowlog.RpcLogDetails;
import org.apache.hadoop.hbase.regionserver.slowlog.SlowLogRecorder;
import org.apache.hadoop.hbase.security.HBasePolicyProvider;
import org.apache.hadoop.hbase.security.SaslUtil;
import org.apache.hadoop.hbase.security.SaslUtil.QualityOfProtection;
import org.apache.hadoop.hbase.security.User;
Expand Down Expand Up @@ -313,6 +314,7 @@ public void onConfigurationChange(Configuration newConf) {
if (scheduler instanceof ConfigurationObserver) {
((ConfigurationObserver) scheduler).onConfigurationChange(newConf);
}
HBasePolicyProvider.init(newConf, authManager);
Copy link
Contributor

@bharathv bharathv Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding thread-safety, do we need to synchronize on authManager while this happens? Otherwise authorize() requests and this init can race and can result in some weird authz results..

Copy link
Contributor Author

@Reidddddd Reidddddd Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

}

protected void initReconfigurable(Configuration confToLoad) {
Expand Down