HBASE-23998. Update license for jetty-client. #1297

jojochuang · 2020-03-17T00:04:32Z

No description provided.

...ver/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java

Apache-HBase · 2020-03-17T07:21:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#1297 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#1297
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T07:22:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#1297 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#1297
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T07:24:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#1297 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#1297
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

(cherry picked from commit 5be67a5)

Apache-HBase · 2020-03-17T23:30:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 12s	master passed
+1 💚	checkstyle	1m 14s	master passed
-1 ❌	spotbugs	2m 12s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 46s	the patch passed
-0 ⚠️	checkstyle	1m 12s	hbase-server: The patch generated 9 new + 1 unchanged - 0 fixed = 10 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 48s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 ❌	spotbugs	2m 23s	hbase-server generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
		_ Other Tests _
-1 ❌	asflicense	0m 13s	The patch generated 1 ASF License warnings.
		45m 32s

Reason	Tests
FindBugs	module:hbase-server
	Possible null pointer dereference of FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setPayloadMethod in org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper$SaslNegotiateHandler$BuilderPayloadSetter.setter(DataTransferProtos$DataTransferEncryptorMessageProto$Builder, byte[]) on exception path Dereferenced at FanOutOneBlockAsyncDFSOutputSaslHelper.java:[line 381]

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1297
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 4e813477b689 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
asflicense	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count	83 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T23:42:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		2m 54s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1297
Optional Tests	dupname asflicense xml
uname	Linux 36d11bad3e59 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Max. process+thread count	41 (vs. ulimit of 10000)
modules	C: hbase-resource-bundle U: hbase-resource-bundle
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T23:54:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 14s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 14s	the patch passed
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 14s	hbase-resource-bundle in the patch passed.
		14m 47s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1297
Optional Tests	javac javadoc unit
uname	Linux 70de729b5988 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Default Java	2020-01-14
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/testReport/
Max. process+thread count	98 (vs. ulimit of 10000)
modules	C: hbase-resource-bundle U: hbase-resource-bundle
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-17T23:54:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 17s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 55s	the patch passed
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 11s	hbase-resource-bundle in the patch passed.
		15m 21s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1297
Optional Tests	javac javadoc unit
uname	Linux f1e0b580f14e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9804f73`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/testReport/
Max. process+thread count	62 (vs. ulimit of 10000)
modules	C: hbase-resource-bundle U: hbase-resource-bundle
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1297/3/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

jojochuang · 2020-03-18T16:20:45Z

@Apache9 the patch is ready. would you like to review? Thanks for your time!

jojochuang · 2020-03-23T16:14:52Z

@Apache9 could you check again?

saintstack · 2020-03-23T18:15:57Z

I can push if you good by you @Apache9

Apache9

+1

This reverts commit b346166.

Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]>

Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]>

(cherry picked from commit 5be67a5)

) Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]>

) Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 5dfd0d8)

Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 5dfd0d8) Co-authored-by: Jan Hentschel <[email protected]>

) (apache#1568) Signed-off-by: stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]> (cherry picked from commit 5dfd0d8) Co-authored-by: Jan Hentschel <[email protected]> (cherry picked from commit bf7487c) Change-Id: I7c0904162f61649c4426d2727612981199b3fb31

Apache9 requested changes Mar 17, 2020

View reviewed changes

...ver/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java Show resolved Hide resolved

jojochuang force-pushed the HBASE-23998 branch 2 times, most recently from 71f02d5 to 5be67a5 Compare March 17, 2020 22:58

HBASE-23998. Update license for jetty-client.

01abfc5

(cherry picked from commit 5be67a5)

jojochuang force-pushed the HBASE-23998 branch from 5be67a5 to 01abfc5 Compare March 17, 2020 22:58

saintstack approved these changes Mar 23, 2020

View reviewed changes

HorizonNet approved these changes Mar 23, 2020

View reviewed changes

Apache9 approved these changes Mar 24, 2020

View reviewed changes

HorizonNet merged commit b346166 into apache:master Apr 12, 2020

HorizonNet added a commit that referenced this pull request Apr 12, 2020

Revert "HBASE-23998. Update license for jetty-client. (#1297)"

46b0685

This reverts commit b346166.

HorizonNet added a commit that referenced this pull request Apr 12, 2020

Revert "HBASE-23998. Update license for jetty-client. (#1297)"

6554e36

This reverts commit b346166.

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23998. Update license for jetty-client. (apache#1297)

243aa4d

(cherry picked from commit 5be67a5)

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23998. Update license for jetty-client. (apache#1297)

bc64b40

(cherry picked from commit 5be67a5)

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23998. Update license for jetty-client. (apache#1297)

338e375

(cherry picked from commit 5be67a5)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-23998. Update license for jetty-client. #1297

HBASE-23998. Update license for jetty-client. #1297

Uh oh!

jojochuang commented Mar 17, 2020

Uh oh!

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

jojochuang commented Mar 18, 2020

Uh oh!

jojochuang commented Mar 23, 2020

Uh oh!

saintstack commented Mar 23, 2020

Uh oh!

Apache9 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HBASE-23998. Update license for jetty-client. #1297

HBASE-23998. Update license for jetty-client. #1297

Uh oh!

Conversation

jojochuang commented Mar 17, 2020

Uh oh!

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

Apache-HBase commented Mar 17, 2020

Uh oh!

jojochuang commented Mar 18, 2020

Uh oh!

jojochuang commented Mar 23, 2020

Uh oh!

saintstack commented Mar 23, 2020

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants