Skip to content

HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WenFeiYi wants to merge 3 commits into from
Closed

HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present #1293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26f6e5
HBASE-23970
Mar 16, 2020
faa310c
pull upstream
Mar 24, 2020
130bb66
HBASE-23970
Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...r/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import java.io.File;
import java.io.IOException;
import java.util.concurrent.TimeUnit;

import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.AuthUtil;
Expand Down Expand Up @@ -64,7 +65,15 @@ public class TestUsersOperationsWithSecureHadoop {
private static String CLIENT_NAME;

@BeforeClass
public static void setUp() throws Exception {
public static void checkAndSetUp() throws Exception {
// check localhost kerberos users
Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c", "klist"});
boolean wait = process.waitFor(2, TimeUnit.SECONDS);
Copy link
Member

@ndimiduk ndimiduk Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple assertTrue is sufficient for this case.

assertTrue("localhost exec klist timeout!", wait);
int ret = process.exitValue();
assertTrue("localhost have an existing ticket!",ret != 0);
Copy link
Member

@ndimiduk ndimiduk May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about about assertNotEquals instead?

Copy link
Contributor Author

@WenFeiYi WenFeiYi Jun 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks. I commit on a new branch


// setup MiniKdc
KDC = TEST_UTIL.setupMiniKdc(KEYTAB_FILE);
PRINCIPAL = "hbase/" + HOST;
CLIENT_NAME = "foo";
Expand Down