HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… #1288

Apache9 · 2020-03-14T03:56:45Z

…efault which is incorrect

saintstack

Thanks

Apache-HBase · 2020-03-14T04:25:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 38s	master passed
+1 💚	compile	0m 28s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 54s	hbase-client in the patch passed.
		24m 50s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1288
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7d2969c8112d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b9e74e0`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/
Max. process+thread count	602 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-14T04:27:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 34s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	5m 3s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 29s	hbase-client in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 12s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	shadedjars	4m 58s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 59s	hbase-client in the patch passed.
		27m 20s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1288
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8bbbc9728681 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b9e74e0`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/
Max. process+thread count	451 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-14T04:38:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 35s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotbugs	1m 4s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 8s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 17s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	spotbugs	1m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		38m 2s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1288
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 0a99b430e763 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b9e74e0`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…efault which is incorrect (#1288) Signed-off-by: stack <[email protected]>

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

…efault which is incorrect (#1288) Signed-off-by: stack <[email protected]>

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]> Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]> (cherry picked from commit 882d2ae) Change-Id: I159f0d05f1a96bd8785fcc0fd7e2ca7c3936f225

…che#1288) Co-authored-by: Rushabh Shah <[email protected]>

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

52604c9

…efault which is incorrect

Apache9 requested a review from saintstack March 14, 2020 03:56

saintstack approved these changes Mar 14, 2020

View reviewed changes

Apache9 merged commit ba3f026 into apache:master Mar 14, 2020

asfgit pushed a commit that referenced this pull request Mar 14, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

26ab594

…efault which is incorrect (#1288) Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Apr 15, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

2d27e8d

…efault which is incorrect (#1288) Signed-off-by: stack <[email protected]>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

6a9ce40

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

889333e

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

71bb097

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Aug 14, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

882d2ae

…efault which is incorrect (#1288) Signed-off-by: stack <[email protected]>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…

c5a8a94

…efault which is incorrect (apache#1288) Signed-off-by: stack <[email protected]>

sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025

@W-18609130 Add metric for last marker row age for FKP migration (apa…

2f40850

…che#1288) Co-authored-by: Rushabh Shah <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… #1288

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… #1288

Uh oh!

Apache9 commented Mar 14, 2020

Uh oh!

saintstack left a comment

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… #1288

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… #1288

Uh oh!

Conversation

Apache9 commented Mar 14, 2020

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Apache-HBase commented Mar 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants