HBASE-23305: Master based registry implementation (#954) #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2020
* HBASE-23604: Cleanup AsyncRegistry interface - Cleans up the method names to make more sense and adds a little more javadocs for context. In future patches we can revisit the name of the actual class to make it more self explanatory. - Does AsyncRegistry -> ConnectionRegistry rename. "async" ness of the registry is kind of implicit based on the interface contents and need not be reflected in the name. Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 12bb41e)
…min (apache#994) * HBASE-23648: Re-use underlying connection registry in RawAsyncHBaseAdmin No need to create and close a new registry on demand. Audited other usages of getRegistry() and the code looks fine. * Fix checkstyle issues in RawAsyncHBaseAdmin (cherry picked from commit 07c3826)
bharathv
force-pushed
the
HBASE-23305-branch-2
branch
from
728bcf2 to
76e397e
Compare
|
💔 -1 overall
This message was automatically generated. |
Implements a master based registry for clients. - Supports hedged RPCs (fan out configured via configs). - Parameterized existing client tests to run with multiple registry combinations. - Added unit-test coverage for the new registry implementation. Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: stack <[email protected]> Signed-off-by: Andrew Purtell <[email protected]>
) Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit fcb2012)
bharathv
force-pushed
the
HBASE-23305-branch-2
branch
from
76e397e to
719d7e1
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
commented
Feb 2, 2020
Contributor
Author
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
This back port to branch-2 includes most of the remaining commits (except the one that switches the default). The couple of failures are flakes. Ready for review.
There were a couple of issues. - There was a leak of a file descriptor for hbck lock file. This was contributing to all the "ConnectionRefused" stack traces since it was trying to renew lease for an already expired mini dfs cluster. This issue was there for a while, just that we noticed it now. - After upgrade to JUnit 4.13, it looks like the behavior for test timeouts has changed. Earlier the timeout seems to have applied for each parameterized run, but now it looks like it is applied across all the runs. This patch fixes both the issues. Signed-off-by: Stack <[email protected]> Signed-off-by: Jan Hentschel <[email protected]> (cherry picked from commit 60cb4f3)
bharathv
force-pushed
the
HBASE-23305-branch-2
branch
from
719d7e1 to
1a1225b
Compare
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Is this the consolidated branch-2 backport? /cc @ndimiduk @saintstack |
Contributor
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-23305: Master based registry implementation (#954)