Skip to content

Conversation

@ndimiduk
Copy link
Member

This is an application for performing an audit between the histories on our git branches and the fixVersion field set on issues in JIRA. It does this by building a Sqlite database from the commits found on each git branch, identifying Jira IDs and release tags, and then requesting information about those issues from Jira. Once both sources have been collected, queries can be performed against the database to look for discrepancies between the sources of truth (and, possibly, bugs in this script).

This is an application for performing an audit between the histories
on our git branches and the `fixVersion` field set on issues in
JIRA. It does this by building a Sqlite database from the commits
found on each git branch, identifying Jira IDs and release tags, and
then requesting information about those issues from Jira. Once both
sources have been collected, queries can be performed against the
database to look for discrepancies between the sources of truth (and,
possibly, bugs in this script).
@ndimiduk
Copy link
Member Author

Heads up release managers/Jira janitors -- @infraio @Apache9 @busbey @apurtell @saintstack @joshelser

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 ❌ pylint 0m 1s Error running pylint. Please check pylint stderr files.
+1 💚 pylint 0m 1s There were no new pylint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
2m 6s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/1/artifact/out/Dockerfile
GITHUB PR #1088
Optional Tests dupname asflicense markdownlint pylint
uname Linux f59b29dd88c7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1088/out/precommit/personality/provided.sh
git revision master / eda5df7
pylint https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/1/artifact/out/patch-pylint-stderr.txt
Max. process+thread count 51 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Jan 24, 2020

long term, this would make a nice contribution to Apache Yetus.

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one doc gap. looks great, let's give it a go.

@ndimiduk
Copy link
Member Author

Huh so the usage of pylint is broken in our personality?

@ndimiduk
Copy link
Member Author

long term, this would make a nice contribution to Apache Yetus.

I generally agree, but I wonder how much of this branching style is hbase-specific.

Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs questions, but this looks great!

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, +1 overall :)

@busbey
Copy link
Contributor

busbey commented Jan 27, 2020

long term, this would make a nice contribution to Apache Yetus.

I generally agree, but I wonder how much of this branching style is hbase-specific.

yeah, I'm totally on board with us using it locally here first and then seeing if it's suitable for others later.

Huh so the usage of pylint is broken in our personality?

shoot, is it? I wonder how long ago that happened. can someone get up a jira with a description and I'll try to find someone to chase it down?

@ndimiduk
Copy link
Member Author

Address PR feedback, burn down the pylint complaints.

@ndimiduk
Copy link
Member Author

shoot, is it? I wonder how long ago that happened. can someone get up a jira with a description and I'll try to find someone to chase it down?

https://issues.apache.org/jira/browse/HBASE-23745

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 ❌ pylint 0m 0s Error running pylint. Please check pylint stderr files.
+1 💚 pylint 0m 0s There were no new pylint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
1m 51s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/2/artifact/out/Dockerfile
GITHUB PR #1088
Optional Tests dupname asflicense markdownlint pylint
uname Linux abb235115cfb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1088/out/precommit/personality/provided.sh
git revision master / 375e01d
pylint https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/2/artifact/out/patch-pylint-stderr.txt
Max. process+thread count 51 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1088/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 5bada0b into apache:master Jan 27, 2020
@ndimiduk ndimiduk deleted the 22853-git-jira-release-audit-tool branch January 27, 2020 18:28
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
* HBASE-22853 Git/Jira Release Audit Tool

This is an application for performing an audit between the histories
on our git branches and the `fixVersion` field set on issues in
JIRA. It does this by building a Sqlite database from the commits
found on each git branch, identifying Jira IDs and release tags, and
then requesting information about those issues from Jira. Once both
sources have been collected, queries can be performed against the
database to look for discrepancies between the sources of truth (and,
possibly, bugs in this script).

Signed-off-by: Sean Busbey <[email protected]>
Signed-off-by: Josh Elser <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
* HBASE-22853 Git/Jira Release Audit Tool

This is an application for performing an audit between the histories
on our git branches and the `fixVersion` field set on issues in
JIRA. It does this by building a Sqlite database from the commits
found on each git branch, identifying Jira IDs and release tags, and
then requesting information about those issues from Jira. Once both
sources have been collected, queries can be performed against the
database to look for discrepancies between the sources of truth (and,
possibly, bugs in this script).

Signed-off-by: Sean Busbey <[email protected]>
Signed-off-by: Josh Elser <[email protected]>
Signed-off-by: Viraj Jasani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants