Skip to content

HBASE-23715 MasterFileSystem should not create MasterProcWALs dir on … #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchevreuil merged 3 commits into from
Jan 23, 2020
Merged

HBASE-23715 MasterFileSystem should not create MasterProcWALs dir on … #1078

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ab0c62
HBASE-23715 MasterFileSystem should not create MasterProcWALs dir on …
wchevreuil Jan 21, 2020
b9916da
fixing checkstyle
wchevreuil Jan 22, 2020
063d7f1
Added extra comment.
wchevreuil Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
import org.apache.hadoop.hbase.fs.HFileSystem;
import org.apache.hadoop.hbase.log.HBaseMarkers;
import org.apache.hadoop.hbase.mob.MobConstants;
import org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore;
import org.apache.hadoop.hbase.regionserver.HRegion;
import org.apache.hadoop.hbase.replication.ReplicationUtils;
import org.apache.hadoop.hbase.security.access.SnapshotScannerHDFSAclHelper;
Expand Down Expand Up @@ -144,11 +143,12 @@ private void createInitialFileSystemLayout() throws IOException {
MobConstants.MOB_DIR_NAME
};

//With the introduction of RegionProcedureStore,
// there's no need to create MasterProcWAL dir here anymore. See HBASE-23715
final String[] protectedSubLogDirs = new String[] {
HConstants.HREGION_LOGDIR_NAME,
HConstants.HREGION_OLDLOGDIR_NAME,
HConstants.CORRUPT_DIR_NAME,
WALProcedureStore.MASTER_PROCEDURE_LOGDIR,
ReplicationUtils.REMOTE_WAL_DIR_NAME
};
// check if the root directory exists
Expand Down