HBASE-23698 Switch central repo to https #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathv
force-pushed
the
HBASE-23698-branch-1
branch
from
b68df72 to
65f2556
Compare
|
💔 -1 overall
This message was automatically generated. |
bharathv
force-pushed
the
HBASE-23698-branch-1
branch
from
65f2556 to
fbe6943
Compare
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Jan 16, 2020
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> |
Contributor
There was a problem hiding this comment.
I checked the parent apache pom (v22) to see if it had this repo in it. It doesn't. Just has apache repo.
This looks good. When you clean your local repo, are you downloading from https?
Thanks
Contributor
Author
There was a problem hiding this comment.
Yes, verified that.
Contributor
|
Its for branch-1 only? |
bharathv
commented
Jan 16, 2020
Contributor
Author
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Its for branch-1 only?
Right now it looks like only branch-1 is affected, probably because branch-1 jobs use an older version of maven (we don't log the version anywhere to confirm that). Like I noted in the jira, mvn versions >= 3.2.3 automatically use https. So folks building locally with latest mvn versions won't hit this issue either.
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> |
Contributor
Author
There was a problem hiding this comment.
Yes, verified that.
Contributor
|
I ran into this and thought the build failure was related to HBASE-23675. |
petersomogyi
approved these changes
Jan 16, 2020
Contributor
petersomogyi
left a comment
petersomogyi
left a comment
There was a problem hiding this comment.
I verified the build using Maven 3.0.5.
petersomogyi
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2020
Signed-off-by: Peter Somogyi <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jan 17, 2020
Signed-off-by: Peter Somogyi <[email protected]>
udaynpusa
pushed a commit
to mapr/hbase
that referenced
this pull request
Jan 30, 2024
Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit 8cb278e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.