Skip to content

Conversation

@HorizonNet
Copy link
Contributor

Backport of #970 to branch-1.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚 mvninstall 8m 22s branch-1 passed
+1 💚 compile 0m 21s branch-1 passed with JDK v1.8.0_232
+1 💚 compile 0m 26s branch-1 passed with JDK v1.7.0_242
+1 💚 checkstyle 0m 37s branch-1 passed
+1 💚 shadedjars 2m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s branch-1 passed with JDK v1.8.0_232
+1 💚 javadoc 0m 25s branch-1 passed with JDK v1.7.0_242
+0 🆗 spotbugs 1m 14s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 12s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 55s the patch passed
+1 💚 compile 0m 20s the patch passed with JDK v1.8.0_232
+1 💚 javac 0m 20s the patch passed
+1 💚 compile 0m 26s the patch passed with JDK v1.7.0_242
+1 💚 javac 0m 26s the patch passed
-1 ❌ checkstyle 0m 31s hbase-rest: The patch generated 1 new + 22 unchanged - 48 fixed = 23 total (was 70)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 48s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 19s the patch passed with JDK v1.8.0_232
+1 💚 javadoc 0m 27s the patch passed with JDK v1.7.0_242
+1 💚 findbugs 1m 13s the patch passed
_ Other Tests _
+1 💚 unit 14m 31s hbase-rest in the patch passed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
46m 38s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/Dockerfile
GITHUB PR #1046
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b6b617a3b334 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revision branch-1 / 907184d
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/diff-checkstyle-hbase-rest.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/testReport/
Max. process+thread count 2058 (vs. ulimit of 10000)
modules C: hbase-rest U: hbase-rest
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be doing /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,4 +1,4 @@
/*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,4 +1,4 @@
/*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,4 @@
/*
*
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a file header and not a javadoc. shouldn't we be using /* instead of /**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
-1 ❌ mvninstall 0m 9s root in branch-1 failed.
-1 ❌ compile 0m 7s hbase-rest in branch-1 failed with JDK v1.8.0_232.
-1 ❌ compile 0m 6s hbase-rest in branch-1 failed with JDK v1.7.0_242.
-1 ❌ checkstyle 0m 5s The patch fails to run checkstyle in hbase-rest
-1 ❌ shadedjars 0m 6s branch has 11 errors when building our shaded downstream artifacts.
-1 ❌ javadoc 0m 6s hbase-rest in branch-1 failed with JDK v1.8.0_232.
-1 ❌ javadoc 0m 8s hbase-rest in branch-1 failed with JDK v1.7.0_242.
+0 🆗 spotbugs 0m 27s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 0m 7s hbase-rest in branch-1 failed.
_ Patch Compile Tests _
-1 ❌ mvninstall 0m 7s root in the patch failed.
-1 ❌ compile 0m 6s hbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌ javac 0m 6s hbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌ compile 0m 7s hbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌ javac 0m 7s hbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌ checkstyle 0m 5s The patch fails to run checkstyle in hbase-rest
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedjars 0m 5s patch has 11 errors when building our shaded downstream artifacts.
-1 ❌ hadoopcheck 0m 6s The patch causes 11 errors with Hadoop v2.8.5.
-1 ❌ hadoopcheck 0m 11s The patch causes 11 errors with Hadoop v2.9.2.
-1 ❌ javadoc 0m 6s hbase-rest in the patch failed with JDK v1.8.0_232.
-1 ❌ javadoc 0m 7s hbase-rest in the patch failed with JDK v1.7.0_242.
-1 ❌ findbugs 0m 8s hbase-rest in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 7s hbase-rest in the patch failed.
+0 🆗 asflicense 0m 7s ASF License check generated no output?
4m 6s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/Dockerfile
GITHUB PR #1046
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 993b0752a80e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revision branch-1 / 907184d
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.8.0_232.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.7.0_242.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-branch-checkstyle-hbase-rest.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.8.0_232.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.7.0_242.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-findbugs-hbase-rest.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-patch-checkstyle-hbase-rest.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.9.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.8.0_232.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.7.0_242.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-findbugs-hbase-rest.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-unit-hbase-rest.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/testReport/
Max. process+thread count 46 (vs. ulimit of 10000)
modules C: hbase-rest U: hbase-rest
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/console
versions git=1.9.1 maven=3.0.5
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 7m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚 mvninstall 9m 47s branch-1 passed
+1 💚 compile 0m 19s branch-1 passed with JDK v1.8.0_242
+1 💚 compile 0m 26s branch-1 passed with JDK v1.7.0_252
+1 💚 checkstyle 0m 36s branch-1 passed
+1 💚 shadedjars 2m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 28s branch-1 passed with JDK v1.8.0_242
+1 💚 javadoc 0m 26s branch-1 passed with JDK v1.7.0_252
+0 🆗 spotbugs 1m 15s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 11s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 55s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK v1.8.0_242
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 26s the patch passed with JDK v1.7.0_252
+1 💚 javac 0m 26s the patch passed
+1 💚 checkstyle 0m 30s hbase-rest: The patch generated 0 new + 21 unchanged - 49 fixed = 21 total (was 70)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 50s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 3s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 19s the patch passed with JDK v1.8.0_242
+1 💚 javadoc 0m 26s the patch passed with JDK v1.7.0_252
+1 💚 findbugs 1m 12s the patch passed
_ Other Tests _
+1 💚 unit 14m 5s hbase-rest in the patch passed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
54m 20s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/artifact/out/Dockerfile
GITHUB PR #1046
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 760cad888e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revision branch-1 / 99a328f
Default Java 1.7.0_252
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/testReport/
Max. process+thread count 2031 (vs. ulimit of 10000)
modules C: hbase-rest U: hbase-rest
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 11 new or modified test files.
_ branch-1 Compile Tests _
+1 💚 mvninstall 8m 43s branch-1 passed
+1 💚 compile 0m 22s branch-1 passed with JDK v1.8.0_242
+1 💚 compile 0m 27s branch-1 passed with JDK v1.7.0_252
+1 💚 checkstyle 0m 37s branch-1 passed
+1 💚 shadedjars 3m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 30s branch-1 passed with JDK v1.8.0_242
+1 💚 javadoc 0m 29s branch-1 passed with JDK v1.7.0_252
+0 🆗 spotbugs 1m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 15s branch-1 passed
-0 ⚠️ patch 1m 25s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 2s the patch passed
+1 💚 compile 0m 23s the patch passed with JDK v1.8.0_242
+1 💚 javac 0m 23s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK v1.7.0_252
+1 💚 javac 0m 28s the patch passed
+1 💚 checkstyle 0m 31s hbase-rest: The patch generated 0 new + 18 unchanged - 33 fixed = 18 total (was 51)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 12s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 22s the patch passed with JDK v1.8.0_242
+1 💚 javadoc 0m 26s the patch passed with JDK v1.7.0_252
+1 💚 findbugs 1m 20s the patch passed
_ Other Tests _
+1 💚 unit 14m 47s hbase-rest in the patch passed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
48m 44s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/artifact/out/Dockerfile
GITHUB PR #1046
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 617896b749df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh
git revision branch-1 / 2e3273f
Default Java 1.7.0_252
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/testReport/
Max. process+thread count 2014 (vs. ulimit of 10000)
modules C: hbase-rest U: hbase-rest
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM.

@HorizonNet HorizonNet merged commit 02d80b2 into apache:branch-1 Jan 23, 2020
@HorizonNet HorizonNet deleted the HBASE-23623_branch-1 branch January 23, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants