-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-23675 Move to Apache parent POM version 22 #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23675 Move to Apache parent POM version 22 #1023
Conversation
|
Seems many pom changes so far are absent in branch-1 and with this, we will get them :) |
This comment has been minimized.
This comment has been minimized.
The tarball looks fine. I ran For the javadoc issue I'm uploading a second commit soon. |
|
From maven-javadoc-plugin 3.0.0 the build fails on JDK8. The configuration moved to a property. |
|
💔 -1 overall
This message was automatically generated. |
| <shell-executable>bash</shell-executable> | ||
| <!-- TODO HBASE-15041 clean up our javadocs so jdk8 linter can be used. | ||
| property as of javadoc-plugin 3.0.0 --> | ||
| <doclint>none</doclint> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok and also we have this present in master and branch-2.
+1 from my side
busbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable to me. please watch the nightly result to make sure the tests for using the generated assembly works there too.
|
Thanks for the reviews, I'll check the nightly. |
Backport to branch-1.