HBASE-23668 Master log start filling with "Flush journal status" messages #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jan 10, 2020
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
I think I can add a UT for this.
You can apply your patch first after changing the minor nits, I will open a new issue to upload the UT.
| conf.set(HRegion.WAL_HSYNC_CONF_KEY, conf.get(USE_HSYNC_KEY)); | ||
| } | ||
| conf.setInt(AbstractFSWAL.RING_BUFFER_SLOT_COUNT, IntMath.ceilingPowerOfTwo(16 * numThreads)); | ||
| conf.setInt(AbstractFSWAL.RING_BUFFER_SLOT_COUNT, |
Contributor
There was a problem hiding this comment.
emmmm, why this format change? What is the max line width in your formatter config?
| changes > flushPerChanges; | ||
| if (flush && LOG.isTraceEnabled()) { | ||
| LOG.trace("shouldFlush memStoreSize={}, flushSize={}, changes={}, flushPerChanges={}", | ||
| region.getMemStoreHeapSize() + region.getMemStoreOffHeapSize(), flushSize, changes, |
Contributor
There was a problem hiding this comment.
These values could change between calls, so I think we'd better store them in a local variable and then log them.
…ages" This reverts commit fb9fa04. i.e. reapplication of patch that was preamaturely applied.
saintstack
force-pushed
the
HBASE-23668.3
branch
from
d09b74b to
aa4c401
Compare
Contributor
Author
|
Address @Apache9 nits. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Manually merged to branch-2 and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ages"
This reverts commit fb9fa04.
i.e. reapplication of patch that was preamaturely applied.