Skip to content

Conversation

@busbey
Copy link
Contributor

@busbey busbey commented Sep 3, 2020

first pass. works for mvn test against the shaded testing utility in HBase 2.2.5. need some more hbase/hadoop version combos.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@busbey
Copy link
Contributor Author

busbey commented Oct 11, 2020

force push was to rebase onto current master branch

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

* WORKDIR already includes the 'htrace-noop' path component.
* missing closing quote
* convert some of the double quotes to single quote
@busbey
Copy link
Contributor Author

busbey commented Jan 24, 2021

Looks like the new test works now to match the testing results I get locally.

ATM this test will only set build status (the little ✔️ or ❌ on a commit and the "checks have passed/failed" at the bottom of the PR discussion) and does not do a comment. If anyone has an issue with this please let me know and I'll see what our options are.

…n to run the htrace replacement tests. remove currently unneeded test matrix exclusion.
@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 spotbugs 0m 1s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 0m 40s master passed
+1 💚 compile 0m 10s master passed
+1 💚 checkstyle 0m 32s master passed
+1 💚 javadoc 0m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 15s the patch passed
+1 💚 javac 0m 15s the patch passed
+1 💚 checkstyle 0m 31s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 0m 25s hbase-noop-htrace in the patch passed.
+1 💚 unit 0m 28s root in the patch passed.
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
4m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/47/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #36
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux f119d85766e0 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / d0a3f39
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/47/testReport/
Max. process+thread count 414 (vs. ulimit of 1000)
modules C: hbase-noop-htrace . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/47/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor Author

busbey commented Jan 24, 2021

the test included here checks the no-op replacement for use with HBase 2.2 and 2.3 combined with Hadoop 3.2 and 2.10.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will depend on this jar in hbase and exclude all other htrace dependencies?

@busbey
Copy link
Contributor Author

busbey commented Jan 26, 2021

Yep! And an existing install can delete the normal htrace jar and put this one in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants