-
Notifications
You must be signed in to change notification settings - Fork 52
HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
force push was to rebase onto current master branch |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… jenkins script variables.
|
Looks like the new test works now to match the testing results I get locally. ATM this test will only set build status (the little ✔️ or ❌ on a commit and the "checks have passed/failed" at the bottom of the PR discussion) and does not do a comment. If anyone has an issue with this please let me know and I'll see what our options are. |
…n to run the htrace replacement tests. remove currently unneeded test matrix exclusion.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
the test included here checks the no-op replacement for use with HBase 2.2 and 2.3 combined with Hadoop 3.2 and 2.10. |
Apache9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we will depend on this jar in hbase and exclude all other htrace dependencies?
|
Yep! And an existing install can delete the normal htrace jar and put this one in place. |
first pass. works for
mvn testagainst the shaded testing utility in HBase 2.2.5. need some more hbase/hadoop version combos.