HBASE-28885 [hbase-thirdparty] Bump hbase.stable.version to 2.5.10 in…

[NihalJain]

… hbase-noop-htrace

• Also move to log4j2 to remove transitive dependency log4j:log4j

[NihalJain]

Unfortunately log4j:log4j is banned in my org and hence I can't build code for that module, hence switched to log4j2!

[NihalJain]

Copied from https://github.com/apache/hbase/blob/master/conf/log4j2.properties

[ndimiduk]

Seems fine. I only wonder if we have an existing config that is tuned for a test environment.

[NihalJain]

There is another one at https://github.com/apache/hbase/blob/master/hbase-logging/src/test/resources/log4j2.properties Not sure if this is also tuned for a test environment though

[NihalJain]

Before:

[INFO] -----------< org.apache.hbase.thirdparty:hbase-noop-htrace >------------
[INFO] Building Apache HBase Drop-in noop HTrace replacement 4.1.11-SNAPSHOT [10/11]
[INFO]   from hbase-noop-htrace/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-noop-htrace ---
[INFO] org.apache.hbase.thirdparty:hbase-noop-htrace:jar:4.1.11-SNAPSHOT
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.apache.hbase:hbase-shaded-testing-util:jar:2.4.17:test
[INFO] |  +- commons-logging:commons-logging:jar:1.2:test
[INFO] |  +- org.slf4j:slf4j-api:jar:1.7.33:test
[INFO] |  +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:test
[INFO] |  +- jakarta.validation:jakarta.validation-api:jar:2.0.2:test
[INFO] |  +- org.glassfish.hk2.external:jakarta.inject:jar:2.6.1:test
[INFO] |  +- org.javassist:javassist:jar:3.25.0-GA:test
[INFO] |  \- org.apache.yetus:audience-annotations:jar:0.13.0:test
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.33:test
[INFO] |  \- log4j:log4j:jar:1.2.17:test
[INFO] \- org.mockito:mockito-all:jar:1.8.5:test

After:

[INFO] -----------< org.apache.hbase.thirdparty:hbase-noop-htrace >------------
[INFO] Building Apache HBase Drop-in noop HTrace replacement 4.1.11-SNAPSHOT [10/11]
[INFO]   from hbase-noop-htrace/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-noop-htrace ---
[INFO] org.apache.hbase.thirdparty:hbase-noop-htrace:jar:4.1.11-SNAPSHOT
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.apache.hbase:hbase-shaded-testing-util:jar:2.5.11:test
[INFO] |  +- io.opentelemetry:opentelemetry-api:jar:1.15.0:test
[INFO] |  +- io.opentelemetry:opentelemetry-context:jar:1.15.0:test
[INFO] |  +- io.opentelemetry:opentelemetry-semconv:jar:1.15.0-alpha:test
[INFO] |  +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:test
[INFO] |  +- jakarta.validation:jakarta.validation-api:jar:2.0.2:test
[INFO] |  +- org.glassfish.hk2.external:jakarta.inject:jar:2.6.1:test
[INFO] |  +- org.javassist:javassist:jar:3.29.2-GA:test
[INFO] |  +- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:test
[INFO] |  +- commons-logging:commons-logging:jar:1.2:test
[INFO] |  \- org.apache.yetus:audience-annotations:jar:0.13.0:test
[INFO] +- org.slf4j:slf4j-api:jar:1.7.33:test
[INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.17.2:test
[INFO] |  +- org.apache.logging.log4j:log4j-api:jar:2.17.2:test
[INFO] |  \- org.apache.logging.log4j:log4j-core:jar:2.17.2:test
[INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.17.2:test
[INFO] \- org.mockito:mockito-all:jar:1.8.5:test
[INFO] 

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	0m 51s	master passed
+1 💚	compile	0m 6s	master passed
+1 💚	javadoc	0m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s	the patch passed
+1 💚	compile	0m 7s	the patch passed
+1 💚	javac	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 41s	hbase-noop-htrace in the patch passed.
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		3m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-132/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR	#132
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux b5b2a3b91689 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
git revision	master / 5bb7b54
Default Java	Temurin-1.8.0_442-b06
Test Results	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-132/2/testReport/
Max. process+thread count	396 (vs. ulimit of 1000)
modules	C: hbase-noop-htrace U: hbase-noop-htrace
Console output	https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-132/2/console
versions	git=2.43.0 maven=3.9.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Seems fine. I only wonder if we have an existing config that is tuned for a test environment.