HADOOP-19798. Add Maven Wrapper #8221
Open
+667
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveloughran
requested changes
Jan 30, 2026
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
key issue is the checksum; we need it
| @@ -0,0 +1,4 @@ | |||
| wrapperVersion=3.3.4 | |||
Contributor
There was a problem hiding this comment.
add an apache header
| import java.nio.file.StandardCopyOption; | ||
| import java.util.concurrent.ThreadLocalRandom; | ||
|
|
||
| public final class MavenWrapperDownloader { |
Contributor
There was a problem hiding this comment.
nit: move to hadoop normal indentation.
Assuming it came from another project, say where it came from
Member
Author
There was a problem hiding this comment.
formatted.
it, mvnw, mvnw.cmd, and maven-wrapper.properties are generated by mvn wrapper:wrapper -Dtype=source
BUILDING.txt
Outdated
| * Unix System | ||
| * JDK 17 | ||
| * Maven 3.3 or later | ||
| * Maven 3.9.11 or later (optional if using ./mvnw) |
Contributor
There was a problem hiding this comment.
say "a compatible version is automatically downloaded if..."
BUILDING.txt
Outdated
| * Windows 10 | ||
| * JDK 17 | ||
| * Maven 3.3 or later (maven.apache.org) | ||
| * Maven 3.9.11 or later (maven.apache.org, optional if using mvnw.cmd) |
| wrapperVersion=3.3.4 | ||
| distributionType=source | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.11/apache-maven-3.9.11-bin.zip | ||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.4/maven-wrapper-3.3.4.jar |
Contributor
There was a problem hiding this comment.
add sha 256 sum in wrapperSha256Sum. The scripts both check it and I don't want unverified binaries being downloaded & executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add Maven Wrapper (
mvnw) as an alternative tomvn, so that developers don't need to worry about Maven version selection and installation.How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
No AI usage.