-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19197. S3A: KMS Encryption Context support: follow-up #8185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
HADOOP-19197. S3A: KMS Encryption Context support: follow-up #8185
Conversation
|
💔 -1 overall
This message was automatically generated. |
cf6ce3d to
ed88a75
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Spotbugs has two failures on classes that weren't modified by this PR I am fine addressing them, but they seem to be false positives. |
ed88a75 to
489e99b
Compare
|
💔 -1 overall
This message was automatically generated. |
Followup the main HADOOP-19197 patch to address serialization and compilation issues * Recreate serialization ID * Restore two arg constructor * Define DEFAULT_S3_ENCRYPTION_CONTEXT to specify what the default value is (just "", but being explicit) * Restore ability to unmarshal old version encryption secrets. * Tests This allows for YARN services to load DTs supplied by older releases. If they marshall the secrets again the fact they were the older version is lost, they get upgraded. This may complicate any worker node launch where the DT list is modified before passing to the launched process
489e99b to
2618511
Compare
|
💔 -1 overall
This message was automatically generated. |
Followup the main HADOOP-19197 patch to address serialization and compilation issues
This allows for YARN services to load DTs supplied by older releases.
If they marshall the secrets again the fact they were the older version is lost, they get upgraded. This may complicate any worker node launch where the DT list is modified before passing to the launched process
This PR squases the commits from #7830 and adds testUnmarshallUnknownEncryptionSecretsVersion for testing EncryptionSecrets with unknown serialize version
How was this patch tested?
Unit tests. ITests failures are meaningless until #7814 is in.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?