-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11913: Remove deprecated properties from yarn-default.xml #8149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
Closes apache#8149 Signed-off-by: Shilun Fan <[email protected]>
|
I pushed up a new test to make sure there are no deprecated properties remaining in yarn-default.xml, similar to suggestions on #8148 . |
|
💔 -1 overall
This message was automatically generated. |
|
The build failure is an unrelated pre-existing problem on trunk that I'm trying to fix in #8150 . |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slfan1989 , are you also still +1 for this one too? This also has a new unit test added after your last review.
LGTM. Thanks for submitting this PR to address the issue! |
|
I committed this to trunk. @slfan1989 and @aajisaka , thank you for the reviews. |
Description of PR
Recent trunk changes now produce more assertive warnings about use of deprecated configuration properties. With some of these deprecated properties included in yarn-default.xml, that means every process launched logs the warnings. Remove them from core-default.xml to avoid these warnings. (Note that this does not take the step of actually removing the code that uses the deprecated properties. They'll continue to work. We just don't want warnings logged by default if the user didn't specifically use these properties.)
How was this patch tested?
Build the distro:
Verify the command above no longer produces deprecation warnings.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?