-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11902.Fix build failure caused by [email protected] #8108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can u assign the jira ticket on your name or drop a comment on the jira with your id, so we can assign the ticket and attribute the contribution to you
Just adding a quick follow-up — since my ASF Jira account setup is still underway, I’m not yet able to self-assign or comment directly on the Jira issue. When convenient, could you please proceed with merging this change? I appreciate your assistance. |
Just a quick follow-up — my ASF Jira account setup is still in progress, so I’m unable to self-assign or comment directly on the Jira issue at the moment. When you get a chance, could you please go ahead and merge this change? Thanks for your help! @slfan1989 @ayushtkn |
Description of PR
JIRA: YARN-11902. Fix Hadoop Yarn UI build failure caused by [email protected].
A build failure occurs in the Yarn UI module during dependency installation due to an incompatible version of [email protected], which enforces a Node.js engine requirement of 20 || 22 || 24.
The current Hadoop build environment uses Node.js 12.22.1, resulting in the following error:
error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || 22 || 24". Got "12.22.1" error Found incompatible module.Root Cause
The mktemp package was pulled in as a transitive dependency.
Version 2.x introduced a strict Node.js engine requirement (≥20), which is incompatible with the current Node 12 environment.
Fix
Pinned the mktemp dependency to a compatible version (0.4.0) using Yarn's resolutions block in package.json:
"resolutions": { "mktemp": "0.4.0" }This resolves the build failure without requiring a Node.js upgrade.
How was this patch tested?
ci
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?