-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17831. Unexpected exception in org.apache.hadoop.hdfs.server.namenode.TestCheckpoint with Java 24 #7961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
PTAL @slfan1989 . |
|
The test failures are pre-existing and not related to my changes. |
|
Can you review this @slfan1989 ? |
|
rebased on trunk |
|
💔 -1 overall
This message was automatically generated. |
…enode.TestCheckpoint with Java 24
|
@slfan1989 @steveloughran |
|
💔 -1 overall
This message was automatically generated. |
| Mockito.doReturn(true).when(faultInjector) | ||
| .shouldSendShortFile(filePathContaining("fsimage")); | ||
| doSendFailTest("is not of the advertised size"); | ||
| String expectedText = Shell.isJavaVersionAtLeast(24) ? "Premature EOF" : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit. put the ? + text on line 658; the : and text on the line afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
💔 -1 overall
This message was automatically generated. |
Description of PR
Java 24 has changed the behaviour for HTTP short reads, and now throws an IOException.
Update the expected Exception for Java 24.
How was this patch tested?
Ran test with Java 8 and 24
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?