Skip to content

MAPREDUCE-7517 TestPipeApplication hangs with JAVA 17+ #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slfan1989 merged 2 commits into from
Sep 11, 2025
Merged

MAPREDUCE-7517 TestPipeApplication hangs with JAVA 17+ #7952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad9801
MAPREDUCE-7517 TestPipeApplication hangs with JAVA 17+
stoty Sep 11, 2025
0515e95
add comment about JRE path
stoty Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ce-client-jobclient/src/test/java/org/apache/hadoop/mapred/pipes/TestPipeApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.concurrent.TimeUnit;

import org.apache.hadoop.fs.CommonConfigurationKeys;
import org.apache.hadoop.fs.FileSystem;
Expand Down Expand Up @@ -69,12 +70,15 @@
import org.apache.hadoop.util.Progressable;
import org.apache.hadoop.yarn.security.AMRMTokenIdentifier;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Timeout.ThreadMode.SEPARATE_THREAD;

@Timeout(value=10, unit = TimeUnit.SECONDS, threadMode = SEPARATE_THREAD)
public class TestPipeApplication {
private static File workSpace = new File("target",
TestPipeApplication.class.getName() + "-workSpace");
Expand Down Expand Up @@ -614,7 +618,8 @@ private File getFileCommand(String clazz) throws Exception {
if (clazz == null) {
os.write(("ls ").getBytes());
} else {
os.write(("java -cp " + classpath + " " + clazz).getBytes());
// On Java 8 java.home returns "${JAVA_HOME}/jre", but that's good enough for this test
os.write((System.getProperty("java.home") + "/bin/java -cp " + classpath + " " + clazz).getBytes());
Copy link
Member

@pan3793 pan3793 Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work.

It might be worth documenting that in Java 8, System.getProperty("java.home") actually returns $JAVA_HOME/jre, commands under $JAVA_HOME/jre/bin are a subset of $JAVA_HOME/bin.

Copy link
Contributor Author

@stoty stoty Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that.

Copy link
Contributor Author

@stoty stoty Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

}
os.flush();
os.close();
Expand Down