-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19343. Add Google Cloud Storage Connector #7656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
arunkumarchacko
wants to merge
8
commits into
apache:HADOOP-19343
from
arunkumarchacko:gcs-connector-create-api
Closed
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ffc0a6d
HADOOP-19343. Add Google Cloud Storage Connector
arunkumarchacko 14d8d96
Fix a javadoc build error
arunkumarchacko 7e203c6
Fix style errors
arunkumarchacko aa6a149
Fix spotbugs and style issues
arunkumarchacko 8ee2957
Remove unused properties from pom.xml
arunkumarchacko 87ec68a
Add specific protobuf version for GCS connector
arunkumarchacko 6901f5d
Add tests
arunkumarchacko 58f1de4
Exclude a spotbug error
arunkumarchacko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <FindBugsFilter> | ||
|
|
||
| <!-- same code as in FileSystem is triggering the same warning. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3native.S3xLoginHelper" /> | ||
| <Method name="checkPath" /> | ||
| <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" /> | ||
| </Match> | ||
| <!-- Redundant null check makes code clearer, future-proof here. --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AFileSystem" /> | ||
| <Method name="s3Exists" /> | ||
| <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" /> | ||
| </Match> | ||
| <!-- we are using completable futures, so ignore the Future which submit() returns --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.impl.InputStreamCallbacksImpl" /> | ||
| <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> | ||
| </Match> | ||
|
|
||
| <!-- | ||
| findbugs gets confused by lambda expressions in synchronized methods | ||
| and considers references to fields to be unsynchronized. | ||
| As you can't disable the methods individually, we have to disable | ||
| them for the entire class. | ||
| --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AInputStream"/> | ||
| <Bug pattern="IS2_INCONSISTENT_SYNC"/> | ||
| </Match> | ||
| <!-- | ||
| findbugs reporting RV ignored. Not true. | ||
| "Return value of S3AReadOpContext.getReadInvoker() ignored, | ||
| but method has no side effect" | ||
| --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AInputStream"/> | ||
| <Method name="reopen"/> | ||
| <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/> | ||
| </Match> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AFileSystem"/> | ||
| <Method name="openFileWithOptions"/> | ||
| <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/> | ||
| </Match> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AFileSystem"/> | ||
| <Field name="futurePool"/> | ||
| <Bug pattern="IS2_INCONSISTENT_SYNC"/> | ||
| </Match> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.s3guard.S3GuardTool$BucketInfo"/> | ||
| <Method name="run"/> | ||
| <Bug pattern="SF_SWITCH_FALLTHROUGH"/> | ||
| </Match> | ||
|
|
||
| <!-- | ||
| Some of the S3A Instrumentation classes increment volatile references from | ||
| within synchronized contexts; they use volatile to keep the cost | ||
| of these updates and reading them down. | ||
| --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.S3AInstrumentation$InputStreamStatisticsImpl"/> | ||
| <Bug pattern="VO_VOLATILE_INCREMENT"/> | ||
| </Match> | ||
|
|
||
| <!-- Ignore return value from this method call --> | ||
| <Match> | ||
| <Class name="org.apache.hadoop.fs.s3a.impl.StoreContext"/> | ||
| <Method name="submit"/> | ||
| <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/> | ||
| </Match> | ||
| </FindBugsFilter> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentionally kept at a lower version for backward-compatibility with other Hadoop RPC clients. HADOOP-17046 has more background. I'm not sure it's safe to upgrade this now. Internally, Hadoop gets its protobuf as a shaded dependency from the hadoop-thirdparty project:
https://github.com/apache/hadoop-thirdparty
Can we use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCS client needs this protobuf version to function. Since the dependency is from GCS client, I do not think we can use hadoop-thridparty.
Thank you for the feedback. I will see if there is any alternate way to resolve this.