Skip to content

HADOOP-19548: [ABFS] Fix Logging in FSDataInputStream to Mention Correct Buffersize #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mukund-thakur merged 4 commits into from
Apr 29, 2025
Merged

HADOOP-19548: [ABFS] Fix Logging in FSDataInputStream to Mention Correct Buffersize #7642

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa78300
log fix
manika137 Apr 22, 2025
43eea22
test and comments
manika137 Apr 24, 2025
37687e1
Merge branch 'trunk' into HADOOP-19548_fixlog
manika137 Apr 29, 2025
8df1b5b
comment suggestions
manika137 Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...p-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,9 @@ public void registerListener(Listener listener1) {

@Override
public FSDataInputStream open(final Path path, final int bufferSize) throws IOException {
LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path, bufferSize);
// bufferSize is unused.
LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path,
Copy link
Contributor

@anujmodi2021 anujmodi2021 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand this from a user's perspective. If someone is calling this method with a buffer size they expect that buffer size to get honoured and if they really want that buffer size to be honored they should know how to make that happen.

Let's add debug something like this: AzureBlobFileSystem.open path: {} bufferSize as configured in "fs.azure.read.request.size": {}", path, abfsStore.getAbfsConfiguration().getReadBufferSize())

Copy link
Contributor Author

@manika137 manika137 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, taken

abfsStore.getAbfsConfiguration().getReadBufferSize());
return open(path, Optional.empty());
}

Expand Down