HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default #7608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Apr 12, 2025
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
The error message on aarch64 ain't cheese
ayushsaxena@ayushsaxena hadoop % ./start-build-env.sh ubuntu_24
[+] Building 0.0s (2/2) FINISHED
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load build definition from Dockerfile_ubuntu_24_aarch64 0.0s
=> => transferring dockerfile: 2B 0.0s
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount1675973539/Dockerfile_ubuntu_24_aarch64: no such file or directory
ayushsaxena@ayushsaxena hadoop %
Can we update the BUILDING.txt to reflect which ones are supported for aarch64.
Rest if the build comes clean, changes LGTM
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
All the failures in compilation are due to below. Nothing to do with changes in this PR. |
vinayakumarb
force-pushed
the
features/HADOOP-19540
branch
from
877f792 to
0db1122
Compare
Contributor
Author
Ack. Updated the BUILDING.txt and added error message in |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Apr 14, 2025
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
LGTM.
Something crazy with the last build as well, see if you can get a clean build, before merging, haven't seen this error before, not sure why is it crying in yarn for protoc
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Ran the failed tests locally.. |
vinayakumarb
force-pushed
the
features/HADOOP-19540
branch
from
0db1122 to
bcd73e6
Compare
|
💔 -1 overall
This message was automatically generated. |
pan3793
reviewed
Apr 22, 2025
pan3793
reviewed
Apr 22, 2025
pan3793
reviewed
Apr 22, 2025
...-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/include/hdfspp/block_location.h
Outdated
Show resolved
Hide resolved
cnauroth
approved these changes
Apr 23, 2025
Contributor
cnauroth
left a comment
cnauroth
left a comment
There was a problem hiding this comment.
+1 from me, pending resolution of the last round of feedback from @pan3793 . Thanks @vinayakumarb !
…7 as default 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
vinayakumarb
force-pushed
the
features/HADOOP-19540
branch
from
bcd73e6 to
1bea33c
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Thanks everyone for reviews. |
Contributor
@vinayakumarb Thank you for the contribution! |
Kimahriman
pushed a commit
to Kimahriman/hadoop
that referenced
this pull request
Jun 10, 2025
…7 as default (apache#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
Contributor
|
@vinayakumarb Should the PR supporting Ubuntu 24 be backported to branch-3.4, even though branch-3.4 currently does not support JDK17? cc: @steveloughran |
Kimahriman
pushed a commit
to Kimahriman/hadoop
that referenced
this pull request
Sep 18, 2025
…7 as default (apache#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
p-szucs
pushed a commit
to p-szucs/hadoop
that referenced
this pull request
Oct 22, 2025
…rm with JDK-17 as default (apache#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
slfan1989
pushed a commit
to slfan1989/hadoop
that referenced
this pull request
Nov 27, 2025
…7 as default (apache#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
slfan1989
added a commit
that referenced
this pull request
Dec 3, 2025
…ch (#8105) * HADOOP-19495. Add JDK 24 to Ubuntu 20.04 docker development images. * HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default (#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24` * HADOOP-19570. Upgrade libxxhash to 0.8.3 in Windows 10 (#7689) * The current version of libxxhash - 0.8.1 isn't available on the msys repo. * This is causing the Hadoop Jenkins CI for Windows to fail while building the docker image for Windows 10. * This PR upgrades libxxhash to 0.8.3 to fix this issue. * HADOOP-19636. [JDK17] Remove CentOS 7 Support and Clean Up Dockerfile. (#7822) * HADOOP-19636. [JDK17] Remove CentOS 7 Support and Clean Up Dockerfile. Co-authored-by: Cheng Pan <chengpan@apache.org> Co-authored-by: Istvan Toth <stoty@apache.org> Reviewed-by: Xiaoqiao He <hexiaoqiao@apache.org> Reviewed-by: Steve Loughran <stevel@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Cheng Pan <chengpan@apache.org> Reviewed-by: Istvan Toth <stoty@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19661. Migrate CentOS 8 to Rocky Linux 8 in build env Dockerfile Closes #7900 Signed-off-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Chris Nauroth <cnauroth@apache.org> * HADOOP-19661. (Follow-up) Rename Dockerfile_centos_8 to Dockerfile_rockylinux_8 (#7917) HADOOP-19661. (Follow-up) Rename Dockerfile_centos_8 to Dockerfile_rockylinux_8. Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile (#7898) Contributed by Cheng Pan. * HADOOP-19659. Upgrade Debian 10 to 11 in build env Dockerfile Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19661. (Follow-up) Install missing deps for Rocky Linux 8 docker image (#7931) Contributed by Cheng Pan. * HADOOP-19661. (Follow-up) Install missing deps for Rocky Linux 8 docker image Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org> * HADOOP-19659. (Follow-up) Install missing procps for Debian 11 docker image (#7932) Contributed by Cheng Pan. * HADOOP-19659. (Follow-up) Install missing procps for Debian 11 docker image. Signed-off-by: Shilun Fan <slfan1989@apache.org> --------- Signed-off-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Chris Nauroth <cnauroth@apache.org> Co-authored-by: Istvan Toth <stoty@apache.org> Co-authored-by: Vinayakumar B <vinayakumarb@apache.org> Co-authored-by: Gautham B A <gautham.bangalore@gmail.com> Co-authored-by: Cheng Pan <chengpan@apache.org>
slfan1989
pushed a commit
that referenced
this pull request
Dec 8, 2025
…7 as default (#7608) 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
Contributor
|
no, this shouldn't have been backported to branch-3.R as it is breaking releases there. |
Contributor
|
update, I'm confused, tried to build on the wrong branch. sorry. I'd actually kicked off a build of trunk in an arm64 ec2 host...if it failed its because the docker image wasn't java17 everywhere... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
start-build-env.shto use expected Dockerfiles dynamically. ex:bash start-build-env.sh ubuntu_24whereubuntu_24is the extra suffix in the name of the Dockerfile.jdk17profile activated when jdk17 is available.#include <stdint.h>to header files which misses it to successfully compile with g++ (13.3) in ubuntu 24.How was this patch tested?
Successfully built the entire Hadoop tar with native support on env created using
bash start-build-env.sh ubuntu_24For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?