-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17720. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs-rbf Part2. #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
2ef522e to
517c532
Compare
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zhtttylz . Thank you for the patch. This is marked as a draft, but it looks good to me. +1. I'll hold off committing until I hear from you again, in case there is some remaining reason you wanted this to remain as a draft.
Thanks for the review! I really appreciate your help. I’ve fixed some checkstyle issues and will move this to open now. |
trigger test again. fix checkstyle. fix checkstyle.
f04fc4a to
c0560ff
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I committed this to trunk. Thank you for the patch, @zhtttylz . @slfan1989 , thank you for reviewing. |
|
Thanks @cnauroth and @slfan1989 for reviewing and merging! |
Description of PR
JIRA:HDFS-17720. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs-rbf Part2.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?