-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19151. Support configurable SASL mechanism. #6740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The mvnsite failure is not related to this. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@jojochuang , thanks a lot for reviewing this! |
|
This MR just makes the algorithm configurable. Are there any recommended configuration values? @szetszwo |
|
Hi @nstang01 , any SASL mechanism listed in https://www.iana.org/assignments/sasl-mechanisms/sasl-mechanisms.xhtml should work. Of course, it is not recommended to use the OBSOLETE mechanisms such as DIGEST-MD5. |
Description of PR
Currently, the SASL mechanism is hard coded to DIGEST-MD5. As mentioned in HADOOP-14811, DIGEST-MD5 is known to be insecure; see rfc6331.
In this JIRA, we will make the SASL mechanism configurable. The default mechanism will still be DIGEST-MD5 in order to maintain compatibility.
We use a new environment variable instead of adding new properties to the xml files since a
Configurationobject may be unavailable when initializing SASL.HADOOP-19151
How was this patch tested?
By existing tests and manually test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?