Skip to content

HDFS-17461. Fix spotbugs in PeerCache#getInternal #6721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hexiaoqiao merged 2 commits into from
Apr 12, 2024
Merged

HDFS-17461. Fix spotbugs in PeerCache#getInternal #6721

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4116fa0
HDFS-17461. Fix spotbugs in PeerCache#getInternal
haiyang1987 Apr 11, 2024
c5e1b9d
HDFS-17461. Modify patch based on comments
haiyang1987 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PeerCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public Peer get(DatanodeID dnId, boolean isDomain) {

private synchronized Peer getInternal(DatanodeID dnId, boolean isDomain) {
List<Value> sockStreamList = multimap.get(new Key(dnId, isDomain));
if (sockStreamList == null) {
if (sockStreamList.isEmpty()) {
return null;
Copy link
Member

@ayushtkn ayushtkn Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just drop this if check itself, the below logic can safely handle an empty list

Copy link
Contributor Author

@haiyang1987 haiyang1987 Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushtkn for your comment.
Update PR, please help me review it again, thanks~

}

Expand Down