HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. #6664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
slfan1989
commented
Mar 27, 2024
dev-support/bin/hadoop.sh
Outdated
| "${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \ | ||
| "${modules[@]}" \ | ||
| -DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ | ||
| -DskipShade -Dsurefire.failIfNoSpecifiedTests=false -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ |
Contributor
Author
There was a problem hiding this comment.
I carefully readed the build report, and -Dsurefire.failIfNoSpecifiedTests=false is necessary because we have some modules without JUnit tests. We use -Dtest=NoUnitTests to handle this, which can cause an error.
Contributor
There was a problem hiding this comment.
can we just make this the default in our pom definitions? I disable tests all the time to run failsafe ITests in the integration phase only.
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@ayushtkn @steveloughran I still want to upgrade this plugin to a higher version. I'm not sure why the number of running unit tests is decreasing. |
steveloughran
requested changes
Apr 3, 2024
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
- I'd like not failing if tests aren't provided to be the default
- some surefire releases don't print stack traces by default. We need that...let's make sure that option is set too
dev-support/bin/hadoop.sh
Outdated
| "${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \ | ||
| "${modules[@]}" \ | ||
| -DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ | ||
| -DskipShade -Dsurefire.failIfNoSpecifiedTests=false -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ |
Contributor
There was a problem hiding this comment.
can we just make this the default in our pom definitions? I disable tests all the time to run failsafe ITests in the integration phase only.
Contributor
Author
@steveloughran Thank you for reviewing pr! I will continue to improve this pr. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Apr 4, 2024
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
there's no need to force the CLI options down, that's to allow overrides in manual runs. in POM files set the options directly
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@steveloughran @ayushtkn The compilation report looks as expected. May I continue with something else? |
Member
|
get a test run on the build, the last yetus report didn't do that. touch something on the root pom & it should do the trick I believe |
Contributor
|
I'm happy with the last change, lets see what yetus says. I propose getting it into trunk and waiting about a week before backporting, just so it's easier to roll back if there are surprises |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@steveloughran @ayushtkn Thanks for reviewing the code! |
Member
|
@slfan1989 did we had a test run in any of the build results? what changed from the previous commit, I doubt we would land up getting the same issues that were present earlier? the last yetus build doesn't have unit tests mentioned only |
Member
|
The build results aren't good some 12K tests vanished A possible reason is VM crashing due to some test & rest all not getting triggered itself, One potential is: This has a OOM & I think lead to VM crash. Debugging the Jenkins results, it has messages like and The file from which I am quoting these are here: Moreover, the tests didn't kick in for all the modules Can check here as well: there is no yarn, no rbf, no aws, no distcp either, a lot of them are missing. Potentially there could be some more memory requirements or some tests crashing the VMs leading to more issues. So, this requires more investigation and efforts |
Contributor
Author
|
Sorry for not following up on this PR promptly. I didn't run the full suite of unit tests but relied on the original CI results. To ensure the next upgrade goes smoothly, I'll run the complete unit tests on a server, compare the results, and provide a report. |
slfan1989
added a commit
that referenced
this pull request
Jun 8, 2024
…5. (#6664)" (#6875) This reverts commit 88ad7db. Signed-off-by: Shilun Fan <[email protected]>
This was referenced Jun 11, 2024
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
…5. (apache#6664)" (apache#6875) This reverts commit 88ad7db. Signed-off-by: Shilun Fan <[email protected]>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
…5. (apache#6664)" (apache#6875) This reverts commit 88ad7db. Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Oct 15, 2024
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Nov 22, 2024
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Nov 23, 2024
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Dec 16, 2024
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Dec 23, 2024
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Mar 25, 2025
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Mar 26, 2025
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
pan3793
pushed a commit
to pan3793/hadoop
that referenced
this pull request
Apr 10, 2025
…he#6664) Contributed by Shilun Fan. Reviewed-by: Steve Loughran <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?