HDFS-17215. RBF: fix some method annotations about @throws . #6136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
xiaojunxiang2023
force-pushed
the
HDFS-17215
branch
from
390c083 to
ad60097
Compare
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Oct 2, 2023
Comment on lines
80
to
81
| * By the way, this latter case actually throws an AccessControlException, | ||
| * which happens to be a subclass of IOException. |
Member
There was a problem hiding this comment.
this isn't required I think,
below it throws ACE directly as well
if (checkMountEntry && isMountEntry(path)) {
throw new AccessControlException(
"Permission denied: " + RouterRpcServer.getRemoteUser()
+ " is not allowed to change quota of " + path);
}
Contributor
Author
There was a problem hiding this comment.
emmm, What I'm trying to show is that this @throw doesn't match what the method actually throws, as shown in the following screenshot
Member
There was a problem hiding this comment.
Correcting that throws to IOE is ok, this Bu the way line isn’t required
Contributor
Author
There was a problem hiding this comment.
Ok, that's a little more concise. I have updated the PR, please check it again.
…s an error, which is described in the @throws section.
xiaojunxiang2023
force-pushed
the
HDFS-17215
branch
from
ad60097 to
119e426
Compare
|
💔 -1 overall
This message was automatically generated. |
slfan1989
requested changes
Oct 3, 2023
Contributor
slfan1989
left a comment
slfan1989
left a comment
There was a problem hiding this comment.
@ayushtkn Thanks for helping review the code! @xiaojunxiang2023 Can we check if a package has the same issue? If we have the same issue, can we fix it in this PR?
xiaojunxiang2023
force-pushed
the
HDFS-17215
branch
from
8588c55 to
082edef
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
I have checked all @throws comments in the rbf module，and fixed them in this PR. |
xinglin
approved these changes
Oct 6, 2023
xiaojunxiang2023
changed the title
simbadzina
approved these changes
Oct 7, 2023
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public void setProto(Message p) { | ||
| public void setProto(Message p) throws IllegalArgumentException { // unchecked exception |
Member
There was a problem hiding this comment.
I think it is not necessary to add the comment // unchecked exception here.
Member
There was a problem hiding this comment.
@xiaojunxiang2023 can you address this? we can commit post this
Member
There was a problem hiding this comment.
I changed it myself, will merge if the build comes green
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira：https://issues.apache.org/jira/browse/HDFS-17215
The setQuota method annotation of the Quota class has an error, which is described in the @throws section.