-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17099. Fix Null Pointer Exception when stop namesystem in HDFS. #6034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 from my side. Will commit if no other comments for two work days.
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @ayushtkn @Hexiaoqiao, are we able to merge this PR if it looks good to you? ;) |
|
Sorry for too late to push forward this PR. |
…pache#6034). Contributed by ConfX. Signed-off-by: Ayush Saxena <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]>
…pache#6034). Contributed by ConfX. Signed-off-by: Ayush Saxena <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]>
Description of PR
https://issues.apache.org/jira/browse/HDFS-17099
This PR adds a null check for
getFSImage().editLogbefore callingupdateLastAppliedTxIdFromWritten.How was this patch tested?
(1) Set
dfs.namenode.top.windows.minutesto37914516,32,0(2) Run test:
org.apache.hadoop.hdfs.server.namenode.TestNameNodeHttpServerXFrame#testSecondaryNameNodeXFrameThe test no longer throws
NullPointerExceptionand throws theIllegalArgumentExceptioninstead, which is expected.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?