Skip to content

HDFS-16985. Fix data missing issue when delete local block file. #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hexiaoqiao merged 7 commits into from
May 14, 2023
Merged

HDFS-16985. Fix data missing issue when delete local block file. #5564

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
710fdc5
HDFS-16985. delete local block file when FileNotFoundException occurr…
Apr 18, 2023
a236be2
Remove missing block info from memory.
Apr 20, 2023
3f7073b
add unit tests.
Apr 23, 2023
1f01e19
fix unchecked conversion.
Apr 25, 2023
0bc5fd7
fix checkstyle.
Apr 25, 2023
f9462ce
fix some nits.
Apr 26, 2023
bad6448
fix checkstyles.
Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,11 +351,16 @@ class BlockSender implements java.io.Closeable {
} catch (FileNotFoundException e) {
if ((e.getMessage() != null) && !(e.getMessage()
.contains("Too many open files"))) {
// The replica is on its volume map but not on disk
// The replica seems is on its volume map but not on disk.
// We can't confirm here is block file lost or disk failed.
// If block lost:
// deleted local block file is completely unnecessary
// If disk failed:
// deleted local block file here may lead to missing-block
// when it with only 1 replication left now.
// So just notify namenode is ok.
datanode
.notifyNamenodeDeletedBlock(block, replica.getStorageUuid());
datanode.data.invalidate(block.getBlockPoolId(),
new Block[] {block.getLocalBlock()});
}
throw e;
} finally {
Expand Down