HADOOP-18450. JavaKeyStoreProvider should throw FileNotFoundException… #5452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Mar 10, 2023
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left a minor comment, looks good otherwise
Comment on lines
+643
to
+645
| if (!fs.exists(src)) { | ||
| throw new FileNotFoundException(src.toUri().toString()); | ||
| } |
Contributor
There was a problem hiding this comment.
How about keeping this check just before fs#rename? Could save efforts of doing rename in the first place?
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in renameOrFail
Description of PR
Attempting to create a key a KMS is configured with the JavaKeystoreProvider and an HDFS store. The calls to:
... fails with an IOException when it attempts to rename a file. The calling code catches FileNotFoundException since the src file may not exist.
Example:
Update the implementation to check for the file, throwing a FileNotFoundException.
How was this patch tested?
Running in an Hadoop development environment docker image.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?