-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11391 Add yarn RM DNS support #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| // If the address needs to be resolved, get all of the IP addresses | ||
| // from this address and pass them into the map | ||
| LOG.info("Multi-A domain name " + addr + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log format uses {}, do not splicing, we should be the way of slf4j
| try { | ||
| address = NetUtils.createSocketAddr(addr); | ||
| } catch (Exception e) { | ||
| LOG.warn("Exception in creating socket address " + addr, e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to pick the patch for new pr. Thanks for the comments, revised.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@lnbest0707 Can we rebase again? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@slfan1989 Tried to rebase multiple times, still same error. Am I doing it in a correct way? Sry for naive questions. |
If the error cannot be resolved, we can recreate a new pr based on the trunk. I think this pr is very valuable, thanks for your contribution. |
|
Close and recreate to bypass some irrelevant errors. |
|
💔 -1 overall
This message was automatically generated. |
Description of PR
The patch reuses the resolver introduced from the HDFS side and apply similar logic to YARN RM service addresses resolving.
To utilize the YARN DNS support and use DNS as endpoint, simply upgrade the hadoop binary and revise configs from, for example:
to:
where rm_multi_a_dns is a multi-A DNS record for rm1_address and rm2_address. This means the following output on the terminal.
For the newly introduced flags, please refer to yarn-default.xml.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?