Skip to content

HDFS-16776 Erasure Coding: The length of targets should be checked when DN gets a reconstruction task #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasanuma merged 4 commits into from
Sep 23, 2022
Merged

HDFS-16776 Erasure Coding: The length of targets should be checked when DN gets a reconstruction task #4901

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
824b84c
init
RuinanGu Sep 17, 2022
5b4abf4
fixed
RuinanGu Sep 18, 2022
77586f5
commit suggestion
RuinanGu Sep 21, 2022
c679261
typo
RuinanGu Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rc/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedReconstructor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,10 @@ RawErasureDecoder getDecoder() {
return decoder;
}

int getNumLiveBlocks(){
return liveBitSet.cardinality();
}

void cleanup() {
if (decoder != null) {
decoder.release();
Expand Down
4 changes: 3 additions & 1 deletion ...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ class StripedWriter {
assert targetStorageIds != null;

writers = new StripedBlockWriter[targets.length];

targetIndices = new short[targets.length];
Preconditions.checkArgument(
targetIndices.length <= dataBlkNum + parityBlkNum - reconstructor.getNumLiveBlocks(),
"Reconstrutcion work gets too much targets.");
Copy link
Member

@tasanuma tasanuma Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidd53685368 Sorry, I have one more request. Reconstrutcion is a typo of Reconstruction.

Preconditions.checkArgument(targetIndices.length <= parityBlkNum,
"Too much missed striped blocks.");
initTargetIndices();
Expand Down