Skip to content

HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mukund-thakur merged 4 commits into from
Aug 15, 2022
Merged

HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset #4730

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75dcd94
HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class…
virajjasani Aug 10, 2022
ada350d
accommodate incorrect enum values provided by user
virajjasani Aug 12, 2022
7f6c75e
addendum
virajjasani Aug 12, 2022
40f0511
debug log + unset in the log msg
virajjasani Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,13 +997,17 @@ protected RequestFactory createRequestFactory() {
String storageClassConf = getConf()
.getTrimmed(STORAGE_CLASS, "")
.toUpperCase(Locale.US);
StorageClass storageClass;
try {
storageClass = StorageClass.fromValue(storageClassConf);
} catch (IllegalArgumentException e) {
LOG.warn("Unknown storage class property {}: {}; falling back to default storage class",
STORAGE_CLASS, storageClassConf);
storageClass = null;
StorageClass storageClass = null;
if (!storageClassConf.isEmpty()) {
try {
storageClass = StorageClass.fromValue(storageClassConf);
} catch (IllegalArgumentException e) {
LOG.warn("Unknown storage class property {}: {}; falling back to default storage class",
STORAGE_CLASS, storageClassConf);
}
} else {
LOG.info("Empty storage class property {}; falling back to default storage class",
Copy link
Contributor

@mukund-thakur mukund-thakur Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We print configuration related logs in debug only unless they are supposed to cause error. So I think this should be debug. right @steveloughran

Copy link
Contributor

@mukund-thakur mukund-thakur Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also shouldn't the log message say " Unset" rather than empty?

Copy link
Contributor

@steveloughran steveloughran Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, debug only, apart from some special cases where there's a risk of incompatibility across versions (dir marker policy). even there i think it is time to retire it.

STORAGE_CLASS);
}

return RequestFactoryImpl.builder()
Expand Down