YARN-11159. Support failApplicationAttempt, updateApplicationPriority, updateApplicationTimeouts API's for Federation #4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, updateApplicationTimeouts API's for Federation.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jun 3, 2022
| LOG.error("Unable to update application priority for {} " + | ||
| "to SubCluster {}.", | ||
| request.getApplicationId(), subClusterId.getId(), e); | ||
| throw e; |
Contributor
Author
There was a problem hiding this comment.
Thanks for your help reviewing the code, your suggestion is correct, I will fix it.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Please help me review the code again, thank you very much, I will follow up on YARN-10122. Can you help merge to trunk branch? |
Contributor
Author
|
@goiri Please help me review the code again, thank you very much! |
goiri
reviewed
Jun 8, 2022
|
|
||
| private SubmitApplicationRequest mockSubmitApplicationRequest( | ||
| ApplicationId appId) { | ||
| ApplicationId appId, int priority) { |
Member
There was a problem hiding this comment.
Can we add one with APP_PRIORITY_ZERO as default instead of having to modify every call?
Contributor
Author
There was a problem hiding this comment.
No problem, I will fix the code.
| () -> interceptor.failApplicationAttempt(null)); | ||
|
|
||
| // normal request | ||
| ApplicationId appId = |
Member
There was a problem hiding this comment.
Single line should fit within limit.
Contributor
Author
There was a problem hiding this comment.
I will fix the code.
| interceptor.getApplicationAttempts(attemptsRequest); | ||
|
|
||
| // Wait for app to start | ||
| while(attemptsResponse.getApplicationAttemptList().size() == 0) { |
Member
There was a problem hiding this comment.
To avoid an active wait, we should do a waitFor() or similar.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I will modify this part of the code.
| Assert.assertNotNull(attemptsResponse); | ||
|
|
||
| String formatISO8601 = | ||
| Times.formatISO8601(System.currentTimeMillis() + 5 * 1000); |
Contributor
Author
There was a problem hiding this comment.
I will fix the code.
Contributor
Author
|
@goiri Please help me review the code again, thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jun 8, 2022
| interceptor.getApplicationAttempts(attemptsRequest); | ||
| Assert.assertNotNull(attemptsResponse); | ||
|
|
||
| String formatISO8601 = |
Member
There was a problem hiding this comment.
This probably should have "time" in the var name.
Contributor
Author
There was a problem hiding this comment.
Thanks for the help reviewing the code, I will fix it.
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jun 9, 2022
Contributor
Author
|
@goiri Thanks for your help to review the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…, updateApplicationTimeouts API's for Federation (apache#4396)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11159. Support failApplicationAttempt, updateApplicationPriority, updateApplicationTimeouts API's for Federation