HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure #4129

tomscut · 2022-04-01T02:25:14Z

As @ayushtkn mentioned here TestRouterDistCpProcedure failed many times because of timeout. I will add a global timeout rule for it. This makes it easy to set the timeout.

hadoop-yetus · 2022-04-01T04:17:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 58s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 23s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 28s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 45s		trunk passed
+1 💚	shadedclient	22m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 14s		the patch passed
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 47s		the patch passed
+1 💚	shadedclient	20m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 41s		hadoop-federation-balance in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		110m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/1/artifact/out/Dockerfile
GITHUB PR	#4129
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux cd829af50bae 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d7af09`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/1/testReport/
Max. process+thread count	705 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-federation-balance U: hadoop-tools/hadoop-federation-balance
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-01T06:42:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 37s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 25s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 46s		trunk passed
+1 💚	shadedclient	20m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 15s		the patch passed
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 46s		the patch passed
+1 💚	shadedclient	20m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 40s		hadoop-federation-balance in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		104m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/2/artifact/out/Dockerfile
GITHUB PR	#4129
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 9134d1d14f84 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d7af09`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/2/testReport/
Max. process+thread count	549 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-federation-balance U: hadoop-tools/hadoop-federation-balance
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

goiri · 2022-04-01T16:05:57Z

...federation-balance/src/test/java/org/apache/hadoop/tools/fedbalance/TestDistCpProcedure.java

          new FileEntry(SRCDAT + "/b/c", false)};
  private static String nnUri;

+  @Rule


Maybe add a comment justifying the long timeout.

Thanks @goiri for your review. I added a comment for this.

hadoop-yetus · 2022-04-02T03:52:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 33s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 25s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 46s		trunk passed
+1 💚	shadedclient	20m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 13s		the patch passed
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 45s		the patch passed
+1 💚	shadedclient	20m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	20m 37s		hadoop-federation-balance in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		104m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/3/artifact/out/Dockerfile
GITHUB PR	#4129
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 9f15c28592c3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7a257ef`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/3/testReport/
Max. process+thread count	680 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-federation-balance U: hadoop-tools/hadoop-federation-balance
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4129/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2022-04-05T08:39:12Z

Thanks @aajisaka for your review.

ayushtkn

LGTM

aajisaka · 2022-04-06T05:34:43Z

Merged. Thank you @tomscut @goiri @ayushtkn

…ache#4129) Reviewed-by: Inigo Goiri <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>

HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure

1d7af09

goiri approved these changes Apr 1, 2022

View reviewed changes

add comment

7a257ef

tomscut mentioned this pull request Apr 2, 2022

HDFS-16477. [SPS]: Add metric PendingSPSPaths for getting the number of paths to be processed by SPS #4009

Merged

aajisaka approved these changes Apr 5, 2022

View reviewed changes

ayushtkn approved these changes Apr 5, 2022

View reviewed changes

aajisaka merged commit 966b773 into apache:trunk Apr 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure #4129

HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure #4129

Uh oh!

tomscut commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

goiri Apr 1, 2022

Uh oh!

tomscut Apr 2, 2022

Uh oh!

hadoop-yetus commented Apr 2, 2022

Uh oh!

tomscut commented Apr 5, 2022

Uh oh!

ayushtkn left a comment

Uh oh!

aajisaka commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure #4129

HDFS-16527. Add global timeout rule for TestRouterDistCpProcedure #4129

Uh oh!

Conversation

tomscut commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

hadoop-yetus commented Apr 1, 2022

Uh oh!

goiri Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

tomscut Apr 2, 2022

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 2, 2022

Uh oh!

tomscut commented Apr 5, 2022

Uh oh!

ayushtkn left a comment

Choose a reason for hiding this comment

Uh oh!

aajisaka commented Apr 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants